starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5671] [CLOSED] Correct position on startup when window is out of screen #26408

New Issue
Open
opened 2026-01-31 09:15:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5671
Author: @dynahcatq
Created: 4/30/2020
Status: ❌ Closed

Base: main ← Head: fix-out-of-screen-pos

📝 Commits (1)

  • de0d146 Correct position when window is out of screen

📊 Changes

1 file changed (+54 additions, -25 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/AppHost.cpp (+54 -25)

📄 Description

Summary of the Pull Request

If the terminal window appears to be off-screen at startup or appears to be partially behind the task bar, reset its position to the top left corner of the screen. Manually tested by giving

References

#4681

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This will reset the window to top-left because the window is partially behind the taskbar:
test1

This will reset the window to top-left because the left side of the window is off the screen:
test2

This will reset the window to top-left because the window is partially off the screen:
test3

For multi-monitor:

Note that this will also reset the window to top-left because the window can fit in a single screen but the window is outside of the screen's work area:
test4

This will reset the window to top-left because the window can fit in a single screen but the window is outside of the screen's work area:
test5

This will reset the window to top-left because the window is partially off the screen:
test6

Note that this will NOT reset the window position to top-left because the window is entirely visible.
test7

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5671 **Author:** [@dynahcatq](https://github.com/dynahcatq) **Created:** 4/30/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-out-of-screen-pos` --- ### 📝 Commits (1) - [`de0d146`](https://github.com/microsoft/terminal/commit/de0d146098570a4848b2707e02265825c9dc92e9) Correct position when window is out of screen ### 📊 Changes **1 file changed** (+54 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+54 -25) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request If the terminal window appears to be off-screen at startup or appears to be partially behind the task bar, reset its position to the top left corner of the screen. Manually tested by giving <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #4681 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3187 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3187 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed This will reset the window to top-left because the window is partially behind the taskbar: <img width="1279" alt="test1" src="https://user-images.githubusercontent.com/14287111/80723098-2eb91900-8ace-11ea-8d63-1d38b7c5b977.png"> This will reset the window to top-left because the left side of the window is off the screen: <img width="1279" alt="test2" src="https://user-images.githubusercontent.com/14287111/80723106-34166380-8ace-11ea-9f96-7e9fe78d2b23.png"> This will reset the window to top-left because the window is partially off the screen: <img width="1279" alt="test3" src="https://user-images.githubusercontent.com/14287111/80723121-37a9ea80-8ace-11ea-916a-44387e5dbb3b.png"> For multi-monitor: Note that this will also reset the window to top-left because the window can fit in a single screen but the window is outside of the screen's work area: <img width="2240" alt="test4" src="https://user-images.githubusercontent.com/14287111/80723130-3a0c4480-8ace-11ea-8f0d-504264e3d17c.png"> This will reset the window to top-left because the window can fit in a single screen but the window is outside of the screen's work area: <img width="1280" alt="test5" src="https://user-images.githubusercontent.com/14287111/80723149-40022580-8ace-11ea-8d86-b8b0d266b10e.png"> This will reset the window to top-left because the window is partially off the screen: <img width="2240" alt="test6" src="https://user-images.githubusercontent.com/14287111/80723159-4395ac80-8ace-11ea-997f-1e5a6af35f91.png"> Note that this will NOT reset the window position to top-left because the window is entirely visible. <img width="2240" alt="test7" src="https://user-images.githubusercontent.com/14287111/80723165-45f80680-8ace-11ea-9250-f1b74d671ebf.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26408
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?