starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5690] Make profile names, scheme names case-insensitive #26434

New Issue
Closed
opened 2026-01-31 09:16:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:05 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/5690

State: closed
Merged: No

Summary of the Pull Request

This PR changes profile names and color scheme names to be treated case-insensitively.

Profiles

  • For new-tab -p <profile name>, <profile name> can be case insensitive
  • For ShortcutActions that use profile (which accepts a "name"), the value of profile can be a case-insensitive name
  • For profiles with the case-insensitive same name, AND NO GUID, we'll still generate different GUIDs for them.
    • If you've got multiple profiles with the case-insensitive same name, only the first profile will be addressable by new-tab -p <name> and newTab actions.

Color Schemes

  • Schemes retain their case sensitive names internally
  • Schemes now layer on schemes with the same case-insensitive name (previously, they'd only layer on schemes with the same case-sensitive name).
  • We use a map<name, Scheme> to store schemes in the app settings. Now, we always store schemes under the std::towlower version of their name in that map.
  • Profiles can now specify a scheme by it's case-insensitive name

References

PR Checklist

  • Lets us rename Campbell Powershell to Campbell PowerShell
  • I work here
  • Tests added/passed
  • Requires documentation to be updated

Validation Steps Performed

  • image
  • Tried setting the color scheme of that profile to "bUiLtIn TaNgO dArK", that worked just fine
  • Added a "BUILTIN TANGO DARK" scheme that changed every color to rgb(255, 0, 0), boy was my terminal RED.
**Original Pull Request:** https://github.com/microsoft/terminal/pull/5690 **State:** closed **Merged:** No --- ## Summary of the Pull Request This PR changes profile names and color scheme names to be treated case-insensitively. #### Profiles * For `new-tab -p <profile name>`, `<profile name>` can be case insensitive * For `ShortcutAction`s that use `profile` (which accepts a "name"), the value of `profile` can be a case-insensitive name * For profiles with the case-insensitive same `name`, AND NO GUID, we'll still generate different GUIDs for them. - If you've got multiple profiles with the case-insensitive same `name`, only the first profile will be addressable by `new-tab -p <name>` and `newTab` actions. #### Color Schemes * Schemes retain their case sensitive `name`s internally * Schemes now layer on schemes with the same case-insensitive `name` (previously, they'd only layer on schemes with the same case-sensitive `name`). * We use a `map<name, Scheme>` to store schemes in the app settings. Now, we always store schemes under the `std::towlower` version of their name in that map. * Profiles can now specify a scheme by it's case-insensitive `name` ## References ## PR Checklist * [x] Lets us rename `Campbell Powershell` to `Campbell PowerShell` * [x] I work here * [x] Tests added/passed * [ ] Requires documentation to be updated ## Validation Steps Performed * ![image](https://user-images.githubusercontent.com/18356694/80822764-03532e80-8ba1-11ea-9a8f-cd200e8d3198.png) * Tried setting the color scheme of that profile to "bUiLtIn TaNgO dArK", that worked just fine * Added a "BUILTIN TANGO DARK" scheme that changed every color to `rgb(255, 0, 0)`, boy was my terminal RED.
claunia added the pull-request label 2026-01-31 09:16:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?