[PR #5774] [MERGED] Add a new appxmanifest for preview #26458

Open
opened 2026-01-31 09:16:14 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5774
Author: @carlos-zamora
Created: 5/6/2020
Status: ✅ Merged
Merged: 5/7/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/new-appxmanifest


📝 Commits (2)

  • 91d180c Add a new appxmanifest for preview
  • 0a53e4f PR comments (thanks Dustin!)

📊 Changes

7 files changed (+180 additions, -17 deletions)

View changed files

📝 build/pipelines/release.yml (+11 -3)
📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+14 -6)
➕ src/cascadia/CascadiaPackage/Package-Pre.appxmanifest (+81 -0)
📝 src/cascadia/CascadiaPackage/Resources/Resources.resw (+66 -1)
📝 src/cascadia/CascadiaResources.build.items (+2 -2)
📝 src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj (+3 -2)
📝 src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj (+3 -3)

📄 Description

Summary of the Pull Request

This adds a new appxmanifest for 'Windows Terminal (Preview)' and links the resources.

Code-wise, split up WindowsTerminalReleaseBuild into...

  • WindowsTerminalOfficialBuild: [true, false]
  • WindowsTerminalBranding: [Dev, Preview, Release]

Added a comment about that in release.yml

Validation Steps Performed

used msbuild to build...

  • Dev
  • Preview
  • Release
    then checked the msix for the correct name/icon.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5774 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 5/6/2020 **Status:** ✅ Merged **Merged:** 5/7/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/new-appxmanifest` --- ### 📝 Commits (2) - [`91d180c`](https://github.com/microsoft/terminal/commit/91d180c2d223d0e34a6172a0241d194abc97aafe) Add a new appxmanifest for preview - [`0a53e4f`](https://github.com/microsoft/terminal/commit/0a53e4fd19d42962a69ddcc928026d894358894b) PR comments (thanks Dustin!) ### 📊 Changes **7 files changed** (+180 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/release.yml` (+11 -3) 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+14 -6) ➕ `src/cascadia/CascadiaPackage/Package-Pre.appxmanifest` (+81 -0) 📝 `src/cascadia/CascadiaPackage/Resources/Resources.resw` (+66 -1) 📝 `src/cascadia/CascadiaResources.build.items` (+2 -2) 📝 `src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj` (+3 -2) 📝 `src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj` (+3 -3) </details> ### 📄 Description ## Summary of the Pull Request This adds a new appxmanifest for 'Windows Terminal (Preview)' and links the resources. Code-wise, split up `WindowsTerminalReleaseBuild` into... - WindowsTerminalOfficialBuild: [true, false] - WindowsTerminalBranding: [Dev, Preview, Release] Added a comment about that in release.yml ## Validation Steps Performed used msbuild to build... - [X] Dev - [X] Preview - [X] Release then checked the msix for the correct name/icon. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:14 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26458