starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5792] [MERGED] Initialize the text buffer with the default attributes on a resize #26466

New Issue
Open
opened 2026-01-31 09:16:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5792
Author: @zadjii-msft
Created: 5/7/2020
Status: ✅ Merged
Merged: 4/21/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/b/3848-resize-color-explosion

📝 Commits (9)

  • 0177498 clean this test up substantially
  • ee92c26 I believe this is the fix for this bug
  • 72e0a55 This should really be in the previous commit as well.
  • f32d1e8 This is another test case for checking the Terminal buffer contents are initialized correctly
  • 1d067cc Make sure to stash the current attributes before the resize, and restore after the resize
  • e945fb3 I believe this is needed here as well.
  • ea66461 Some test cleanup for review
  • 46d6d68 This test passes without any resizing involved
  • c3f9d36 update for merge with main

📊 Changes

3 files changed (+169 additions, -3 deletions)

View changed files

📝 src/cascadia/TerminalCore/Terminal.cpp (+10 -1)
📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+150 -1)
📝 src/host/screenInfo.cpp (+9 -1)

📄 Description

When we resize the text buffer, initialize the buffer with the
_default_¹ attributes, not the current ones. If we use the current
attributes, then we can get into scenarios where something like vim is
running, and left the attributes set to something other than the
defaults, and when we resized the buffer, we'd fill it up with color, as
opposed to whatever the default would be.

This PR instead initializes the buffers with the default colors. It also
makes sure to set the active attributes of the newly created buffers
back to whatever the current attributes of the old buffer were.

[1]: For the Terminal, the default attributes are "default on default".
For conhost, the default attributes are whatever the result of
Settings::GetDefaultAttributes is, which could be any combo of the
legacy indices and the default color.

PR Checklist

Validation Steps Performed

  • ran tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5792 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/7/2020 **Status:** ✅ Merged **Merged:** 4/21/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/3848-resize-color-explosion` --- ### 📝 Commits (9) - [`0177498`](https://github.com/microsoft/terminal/commit/01774989cc9550f5909421f3ffc21a563d9471d8) clean this test up substantially - [`ee92c26`](https://github.com/microsoft/terminal/commit/ee92c26859de58ccec9f51b64c1bdff46a96157c) I believe this is the fix for this bug - [`72e0a55`](https://github.com/microsoft/terminal/commit/72e0a5552cb30dbd21f7240729dbe95a2ca3fdbe) This should really be in the previous commit as well. - [`f32d1e8`](https://github.com/microsoft/terminal/commit/f32d1e853417e7e4c6276f781e684daa0843bd00) This is another test case for checking the Terminal buffer contents are initialized correctly - [`1d067cc`](https://github.com/microsoft/terminal/commit/1d067cc35fd6f20d5033477753c42aef5741d58e) Make sure to stash the current attributes before the resize, and restore after the resize - [`e945fb3`](https://github.com/microsoft/terminal/commit/e945fb30b71f8d35fa1f3d0b00658897c13b8296) I believe this is needed here as well. - [`ea66461`](https://github.com/microsoft/terminal/commit/ea66461a674a660d35cd8f0321a58e3ffdb1913c) Some test cleanup for review - [`46d6d68`](https://github.com/microsoft/terminal/commit/46d6d688b1a693446c37dd2c6dd193f513942d88) This test passes without any resizing involved - [`c3f9d36`](https://github.com/microsoft/terminal/commit/c3f9d36b1b87728b030d1936ad774ee5ffaf7561) update for merge with main ### 📊 Changes **3 files changed** (+169 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+10 -1) 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+150 -1) 📝 `src/host/screenInfo.cpp` (+9 -1) </details> ### 📄 Description When we resize the text buffer, initialize the buffer with the _default_¹ attributes, not the _current_ ones. If we use the current attributes, then we can get into scenarios where something like `vim` is running, and left the attributes set to something other than the defaults, and when we resized the buffer, we'd fill it up with color, as opposed to whatever the default would be. This PR instead initializes the buffers with the default colors. It also makes sure to set the active attributes of the newly created buffers back to whatever the current attributes of the old buffer were. [1]: For the Terminal, the default attributes are "default on default". For conhost, the default attributes are whatever the result of `Settings::GetDefaultAttributes` is, which could be any combo of the legacy indices and the default color. ## PR Checklist * [x] Closes #3848 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * ran tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26466
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?