[PR #5804] [MERGED] Introduce Mark Mode spec (add-on) #26477

Open
opened 2026-01-31 09:16:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5804
Author: @carlos-zamora
Created: 5/8/2020
Status: Merged
Merged: 7/23/2022
Merged by: @DHowett

Base: mainHead: dev/cazamor/spec-ks/mark-mode


📝 Commits (10+)

  • 51e8b1a Keyboard Selection Spec
  • bc668e0 PR changes (first of many)
  • 67c6334 Updated to reflect Keybinding Args change
  • 4f38557 include 'shift' in keybindings
  • de95782 more mark mode details. Added responses to PR feedback into the spec
  • 23b425e remove mark mode for separate PR (easier discussion)
  • f71275c PR changes
  • 81c5a7c Merge branch 'master' into dev/cazamor/spec-keyboard-selection
  • de8dc2f Merge branch 'master' into dev/cazamor/spec-keyboard-selection
  • 3af5ae6 update default bindings

📊 Changes

8 files changed (+282 additions, -171 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -0)
doc/specs/#4993 - Keyboard Selection/Keyboard-Selection.md (+281 -0)
doc/specs/#4993 - Keyboard Selection/images/CopyModeFlowchart.png (+0 -0)
doc/specs/#4993 - Keyboard Selection/images/CopyModeFlowchart.vsdx (+0 -0)
doc/specs/#4993 - Keyboard Selection/images/Half-Y-Beam.png (+0 -0)
doc/specs/#4993 - Keyboard Selection/images/Split-Y-Beam.png (+0 -0)
doc/specs/#4993 - Keyboard Selection/images/Y-Beam.png (+0 -0)
doc/specs/Keyboard-Selection.md (+0 -171)

📄 Description

Summary of the Pull Request

This is a spec specifically dedicated to Mark Mode. It's an addition to the Keyboard Selection spec. I felt that it makes the most sense to make this a separate PR because there's a lot of ideas that are very specific to Mark Mode, and this gives us the space to modify some of that behavior and get a good look at how other terminal emulators designed this feature.

References

#2840 - Keyboard Selection Spec (base spec/branch/PR)

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5804 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 5/8/2020 **Status:** ✅ Merged **Merged:** 7/23/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/cazamor/spec-ks/mark-mode` --- ### 📝 Commits (10+) - [`51e8b1a`](https://github.com/microsoft/terminal/commit/51e8b1a34e040b68e006c137890d133b111d4036) Keyboard Selection Spec - [`bc668e0`](https://github.com/microsoft/terminal/commit/bc668e0cbd47f96478d365a27a7f121ebca4f003) PR changes (first of many) - [`67c6334`](https://github.com/microsoft/terminal/commit/67c6334cd3d2d501631592df278380300538a654) Updated to reflect Keybinding Args change - [`4f38557`](https://github.com/microsoft/terminal/commit/4f38557626f3bf084c5dc2b4fc6ee956a21f6de4) include 'shift' in keybindings - [`de95782`](https://github.com/microsoft/terminal/commit/de95782692a8fe6e0e30118046cd67613cbed047) more mark mode details. Added responses to PR feedback into the spec - [`23b425e`](https://github.com/microsoft/terminal/commit/23b425eaae2b259cedaf6c5139ceb2bfdf939a95) remove mark mode for separate PR (easier discussion) - [`f71275c`](https://github.com/microsoft/terminal/commit/f71275c8c015907224d862366fe08a92b2870996) PR changes - [`81c5a7c`](https://github.com/microsoft/terminal/commit/81c5a7c81016d3d905b6563dbb4e75c3656fab91) Merge branch 'master' into dev/cazamor/spec-keyboard-selection - [`de8dc2f`](https://github.com/microsoft/terminal/commit/de8dc2f253c6af955c32d819c0a6d7a07077c7c8) Merge branch 'master' into dev/cazamor/spec-keyboard-selection - [`3af5ae6`](https://github.com/microsoft/terminal/commit/3af5ae6b5957b03f50033d3da21d42cbbeb93781) update default bindings ### 📊 Changes **8 files changed** (+282 additions, -171 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -0) ➕ `doc/specs/#4993 - Keyboard Selection/Keyboard-Selection.md` (+281 -0) ➕ `doc/specs/#4993 - Keyboard Selection/images/CopyModeFlowchart.png` (+0 -0) ➕ `doc/specs/#4993 - Keyboard Selection/images/CopyModeFlowchart.vsdx` (+0 -0) ➕ `doc/specs/#4993 - Keyboard Selection/images/Half-Y-Beam.png` (+0 -0) ➕ `doc/specs/#4993 - Keyboard Selection/images/Split-Y-Beam.png` (+0 -0) ➕ `doc/specs/#4993 - Keyboard Selection/images/Y-Beam.png` (+0 -0) ➖ `doc/specs/Keyboard-Selection.md` (+0 -171) </details> ### 📄 Description ## Summary of the Pull Request This is a spec specifically dedicated to Mark Mode. It's an addition to the Keyboard Selection spec. I felt that it makes the most sense to make this a separate PR because there's a lot of ideas that are very specific to Mark Mode, and this gives us the space to modify some of that behavior and get a good look at how other terminal emulators designed this feature. ## References #2840 - Keyboard Selection Spec (base spec/branch/PR) ## PR Checklist * [X] Contributes to #715 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26477