starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ignore json profile data not understood #2648

New Issue
Closed
opened 2026-01-30 23:01:10 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 23:01:10 +00:00
Owner
Copy Link

Originally created by @fredless on GitHub (Jul 8, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Summary of the new feature/enhancement

Current implementation seems to clean up json parameters entries in the config file not understood or implemented. Rather than removing unknown parameters, perhaps just ignore them.

Proposed technical implementation details (optional)

Moving\syncing profiles.json between profiles\machines with differing builds (i.e. msftstore release versus "nightly") can result in undesired configuration removal. If you are 2-way syncing profile data it's even worse: configuration removal would head back to the source machine, where the configuration was valid.

Originally created by @fredless on GitHub (Jul 8, 2019). Originally assigned to: @zadjii-msft on GitHub. # Summary of the new feature/enhancement Current implementation seems to clean up json ~~parameters~~ *entries in the config file* not understood or implemented. Rather than removing unknown parameters, perhaps just ignore them. # Proposed technical implementation details (optional) Moving\syncing profiles.json between profiles\machines with differing builds (i.e. msftstore release versus "nightly") can result in undesired configuration removal. If you are 2-way syncing profile data it's even worse: configuration removal would head back to the source machine, where the configuration was valid.
claunia added the Area-SettingsIssue-TaskNeeds-Tag-FixProduct-Terminal labels 2026-01-30 23:01:10 +00:00
claunia commented 2026-01-30 23:01:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 11, 2019):

This is something that will be fixed by the work that needs to be done for #754. I'll parent it to that deliverable.

@zadjii-msft commented on GitHub (Jul 11, 2019): This is something that _will_ be fixed by the work that needs to be done for #754. I'll parent it to that deliverable.
claunia commented 2026-01-30 23:01:12 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 19, 2019):

This is done as of #(the pull request that disabled settings reserialization), actually.

@DHowett-MSFT commented on GitHub (Sep 19, 2019): This is done as of #(the pull request that disabled settings reserialization), actually.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2648
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?