[PR #5817] [MERGED] build: merge the signing steps and wildcard them #26486

Open
opened 2026-01-31 09:16:23 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5817
Author: @DHowett-MSFT
Created: 5/8/2020
Status: Merged
Merged: 5/8/2020
Merged by: @DHowett-MSFT

Base: masterHead: dev/duhowett/signconfig


📝 Commits (1)

  • c95da5d build: merge the signing steps and wildcard them

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 build/config/SignConfig.WindowsTerminal.xml (+1 -2)

📄 Description

This allows me to make the build pipeline, instead of the release
engineer, put the version number in the package name.

It also lets us sign multiple packages (if we ever produce more than
one.)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5817 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 5/8/2020 **Status:** ✅ Merged **Merged:** 5/8/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/signconfig` --- ### 📝 Commits (1) - [`c95da5d`](https://github.com/microsoft/terminal/commit/c95da5da66030439db7193c054cf94314a7f62ba) build: merge the signing steps and wildcard them ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `build/config/SignConfig.WindowsTerminal.xml` (+1 -2) </details> ### 📄 Description This allows me to make the build pipeline, instead of the release engineer, put the version number in the package name. It also lets us sign _multiple packages_ (if we ever produce more than one.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:23 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26486