starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5849] [CLOSED] Dialogue to show all keyboard shortcuts #26496

New Issue
Open
opened 2026-01-31 09:16:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:26 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5849
Author: @Chips1234
Created: 5/11/2020
Status: ❌ Closed

Base: master ← Head: dev/chips1234/dialog-to-show-all-shortcuts

📝 Commits (10+)

  • 8a076bc Merge pull request #1 from microsoft/master
  • c044f53 Added tooltip text for MinMaxCloseControl
  • e96de7e Merge pull request #1 from Chips1234/dev/chips1234/tooltip-text(from-resources)
  • a139c7b Tooltip Text for New Tab Split Button
  • 62751c1 Merge pull request #2 from Chips1234/dev/chips1234/tooltip-text(from-resources)-1
  • 7ff46af Merge remote-tracking branch 'upstream/master'
  • d368245 Made the design for the dialog
  • 9cbe1e9 Update RESW file for dialog items
  • c65bf56 Create Key bindings menu item.
  • 6b490f3 Put in the code for the button

📊 Changes

4 files changed (+113 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+47 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+37 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+27 -0)

📄 Description

Summary of the Pull Request

Adds a dialogue that shows all keyboard shortcuts. If I'm missing anything, feel free to share!

References

Connected to #4695.

PR Checklist

  • Closes Right-click shell integration (#4695)
  • CLA signed. If not, go over here and sign the CLA
  • No documents
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

A new dialogue launched by clicking on a new tab menu item.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5849 **Author:** [@Chips1234](https://github.com/Chips1234) **Created:** 5/11/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/chips1234/dialog-to-show-all-shortcuts` --- ### 📝 Commits (10+) - [`8a076bc`](https://github.com/microsoft/terminal/commit/8a076bc595b63bd53ff74ff24c1e704e0988de8c) Merge pull request #1 from microsoft/master - [`c044f53`](https://github.com/microsoft/terminal/commit/c044f53c69ae1d73041d1f63483308604e9be1e9) Added tooltip text for MinMaxCloseControl - [`e96de7e`](https://github.com/microsoft/terminal/commit/e96de7e483b52584178f5b225fc83afc62caad0e) Merge pull request #1 from Chips1234/dev/chips1234/tooltip-text(from-resources) - [`a139c7b`](https://github.com/microsoft/terminal/commit/a139c7b067b44b133419b7ffee0747c0e692f89b) Tooltip Text for New Tab Split Button - [`62751c1`](https://github.com/microsoft/terminal/commit/62751c19f373cc3c5aa64a82f461ecc2782d5de1) Merge pull request #2 from Chips1234/dev/chips1234/tooltip-text(from-resources)-1 - [`7ff46af`](https://github.com/microsoft/terminal/commit/7ff46affb6dc9b9dadc0ca0e9bebda5be9b27ba6) Merge remote-tracking branch 'upstream/master' - [`d368245`](https://github.com/microsoft/terminal/commit/d36824586597526767aa74be9ff3947306197679) Made the design for the dialog - [`9cbe1e9`](https://github.com/microsoft/terminal/commit/9cbe1e9035cab52be901e8b0bc599d46f4d690b7) Update RESW file for dialog items - [`c65bf56`](https://github.com/microsoft/terminal/commit/c65bf56eb32fac618f174877e787abe55d94fbf9) Create Key bindings menu item. - [`6b490f3`](https://github.com/microsoft/terminal/commit/6b490f36593c5b221c5af445b8685e3df47d669b) Put in the code for the button ### 📊 Changes **4 files changed** (+113 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+47 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+37 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+27 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds a dialogue that shows all keyboard shortcuts. If I'm missing anything, feel free to share! <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References Connected to #4695. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #4695 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [X] No documents * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments A new dialogue launched by clicking on a new tab menu item. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26496
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?