starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5855] [MERGED] Stop trying to set selection endpoints when there's no selection #26508

New Issue
Open
opened 2026-01-31 09:16:29 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:29 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5855
Author: @DHowett-MSFT
Created: 5/12/2020
Status: ✅ Merged
Merged: 5/12/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/who_would_use_a_terminal_like_this_anyway,_i_ask_you

📝 Commits (1)

  • faf9581 Don't let selection endpoints be set when there's no selection

📊 Changes

2 files changed (+12 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+5 -0)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+7 -0)

📄 Description

Apparently, this accounts for somewhere between 7% and 14% of our
crashes on 1.0RC1.

Summary of the Pull Request

It turns out that we weren't really adequately guarding calls to SetSelectionEnd and friends.

PR Checklist

  • Closes internal crash report
  • CLA
  • Tests passed
  • Requires documentation to be updated
  • One with the corefolk

Detailed Description of the Pull Request / Additional comments

I decided that it would be prudent to add a WIL log.

Validation Steps Performed

First, I figured out how the heck to repro this. Snap the window, begin a selection, then use Win+Up to resize it. Then, I fixed it and tried the repro again.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5855 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 5/12/2020 **Status:** ✅ Merged **Merged:** 5/12/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/who_would_use_a_terminal_like_this_anyway,_i_ask_you` --- ### 📝 Commits (1) - [`faf9581`](https://github.com/microsoft/terminal/commit/faf9581c85253648267908702dc32215c05a4da7) Don't let selection endpoints be set when there's no selection ### 📊 Changes **2 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+5 -0) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+7 -0) </details> ### 📄 Description Apparently, this accounts for somewhere between 7% and 14% of our crashes on 1.0RC1. ## Summary of the Pull Request It turns out that we weren't really adequately guarding calls to SetSelectionEnd and friends. ## PR Checklist * [x] Closes internal crash report * [x] CLA * [x] Tests passed * [ ] Requires documentation to be updated * [x] One with the corefolk ## Detailed Description of the Pull Request / Additional comments I decided that it would be prudent to add a WIL log. ## Validation Steps Performed First, I figured out how the heck to repro this. Snap the window, begin a selection, then use <kbd>Win+Up</kbd> to resize it. Then, I fixed it and tried the repro again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26508
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?