starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5866] [MERGED] Revert some emoji back to narrow width #26509

New Issue
Open
opened 2026-01-31 09:16:29 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:29 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5866
Author: @leonMSFT
Created: 5/12/2020
Status: ✅ Merged
Merged: 5/12/2020
Merged by: @undefined

Base: master ← Head: dev/lelian/emojitoobig

📝 Commits (3)

  • e4e62d9 removed card suites, male+female sign, smiley face as wides as per CP437
  • 422be68 comment
  • ae6360a oh spellcheck why must you block me so

📊 Changes

2 files changed (+7 additions, -7 deletions)

View changed files

📝 .github/actions/spell-check/whitelist/whitelist.txt (+1 -0)
📝 src/types/CodepointWidthDetector.cpp (+6 -7)

📄 Description

A couple of codepoints, namely the card suites, male and female signs,
and white and black smiling faces were changed to have a two-column
width as part of #5795 since they were specified as emoji in Unicode's
emoji list v13.0[1].

These particular glyphs also show up in some of the most fundamental
code pages, such as CP437[2] and WGL4[3]. We should
not be touching the width of the glyphs in these codepages, as suddenly
changing a long-time-running narrow glyph to use two-columns all of a
sudden will surely break (and has already broken) things.

[1] https://www.unicode.org/Public/13.0.0/ucd/emoji/emoji-data.txt
[2] https://en.wikipedia.org/wiki/Code_page_437
[3] https://en.wikipedia.org/wiki/Windows_Glyph_List_4

Closes #5822

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5866 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 5/12/2020 **Status:** ✅ Merged **Merged:** 5/12/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/lelian/emojitoobig` --- ### 📝 Commits (3) - [`e4e62d9`](https://github.com/microsoft/terminal/commit/e4e62d90e63c1e35feff578e070abe72184461c9) removed card suites, male+female sign, smiley face as wides as per CP437 - [`422be68`](https://github.com/microsoft/terminal/commit/422be68ba36b12945a00626e07f1e23f576b8ead) comment - [`ae6360a`](https://github.com/microsoft/terminal/commit/ae6360a6000c1cb79aefe6a791992e3ec0b15776) oh spellcheck why must you block me so ### 📊 Changes **2 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spell-check/whitelist/whitelist.txt` (+1 -0) 📝 `src/types/CodepointWidthDetector.cpp` (+6 -7) </details> ### 📄 Description A couple of codepoints, namely the card suites, male and female signs, and white and black smiling faces were changed to have a two-column width as part of #5795 since they were specified as emoji in Unicode's emoji list v13.0[1]. These particular glyphs also show up in some of the most fundamental code pages, such as CP437[2] and WGL4[3]. We should not be touching the width of the glyphs in these codepages, as suddenly changing a long-time-running narrow glyph to use two-columns all of a sudden will surely break (and has already broken) things. [1] https://www.unicode.org/Public/13.0.0/ucd/emoji/emoji-data.txt [2] https://en.wikipedia.org/wiki/Code_page_437 [3] https://en.wikipedia.org/wiki/Windows_Glyph_List_4 Closes #5822 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?