[PR #5856] Teach TerminalPage to handle exceptions that happen during paste #26512

Open
opened 2026-01-31 09:16:30 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/5856

State: closed
Merged: Yes


Summary of the Pull Request

Terminal should try not to join the choir invisible when the clipboard
API straight up horks it.

This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the crashes
seen all-up in the last 14 days.

Fixes #4906.

PR Checklist

Validation Steps Performed

Found out a surefire way to repro it!

"copyOnSelect": true

Copy something small.

Hold down Ctrl+Shift+V

Double-click like your life depends on it. Double-click like you're
playing cookie clicker again. 2013 called, it wants its cookies back.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/5856 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Terminal should try not to join the choir invisible when the clipboard API straight up horks it. This accounts for ~3% of the crashes seen in 1.0RC1 and ~1% of the crashes seen all-up in the last 14 days. Fixes #4906. ## PR Checklist * [x] Closes #4906 * [x] CLA'd * [ ] Tests passed/do not exist * [ ] Requires documentation to be updated * [x] Meh ## Validation Steps Performed Found out a surefire way to repro it! `"copyOnSelect": true` Copy something small. Hold down <kbd>Ctrl+Shift+V</kbd> Double-click like your life depends on it. Double-click like you're playing cookie clicker again. 2013 called, it wants its cookies back.
claunia added the pull-request label 2026-01-31 09:16:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26512