[PR #5855] Stop trying to set selection endpoints when there's no selection #26513

Open
opened 2026-01-31 09:16:30 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/5855

State: closed
Merged: Yes


Apparently, this accounts for somewhere between 7% and 14% of our
crashes on 1.0RC1.

Summary of the Pull Request

It turns out that we weren't really adequately guarding calls to SetSelectionEnd and friends.

PR Checklist

  • Closes internal crash report
  • CLA
  • Tests passed
  • Requires documentation to be updated
  • One with the corefolk

Detailed Description of the Pull Request / Additional comments

I decided that it would be prudent to add a WIL log.

Validation Steps Performed

First, I figured out how the heck to repro this. Snap the window, begin a selection, then use Win+Up to resize it. Then, I fixed it and tried the repro again.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/5855 **State:** closed **Merged:** Yes --- Apparently, this accounts for somewhere between 7% and 14% of our crashes on 1.0RC1. ## Summary of the Pull Request It turns out that we weren't really adequately guarding calls to SetSelectionEnd and friends. ## PR Checklist * [x] Closes internal crash report * [x] CLA * [x] Tests passed * [ ] Requires documentation to be updated * [x] One with the corefolk ## Detailed Description of the Pull Request / Additional comments I decided that it would be prudent to add a WIL log. ## Validation Steps Performed First, I figured out how the heck to repro this. Snap the window, begin a selection, then use <kbd>Win+Up</kbd> to resize it. Then, I fixed it and tried the repro again.
claunia added the pull-request label 2026-01-31 09:16:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26513