[PR #5918] Remove the JSON reserializers (except for AKB) #26536

Open
opened 2026-01-31 09:16:41 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/5918

State: closed
Merged: Yes


The AKB serializer is used in the tracelogging pipeline.

Chatted with @zadjii-msft about ganking the deserializers. The form they'll take in the future is probably very different from this.

We'll need to have some better tracking of the source or pass a setting was read during so that we can accurately construct an internal settings attribution model. Diffing was very extremely cool, but we didn't end up needing it.

This apparently drops our binary size by a whopping zero bytes because the optimizer was smarter than us and actually totally deleted it.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/5918 **State:** closed **Merged:** Yes --- The AKB serializer is used in the tracelogging pipeline. Chatted with @zadjii-msft about ganking the deserializers. The form they'll take in the future is probably very different from this. We'll need to have some better tracking of the _source_ or _pass_ a setting was read during so that we can accurately construct an internal settings attribution model. Diffing was very extremely cool, but we didn't end up needing it. This apparently drops our binary size by a whopping _zero bytes_ because the optimizer was smarter than us and actually totally deleted it.
claunia added the pull-request label 2026-01-31 09:16:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26536