[PR #5988] [MERGED] Make sure to update the maximize button's visual state on launch #26563

Open
opened 2026-01-31 09:16:49 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5988
Author: @zadjii-msft
Created: 5/19/2020
Status: ✅ Merged
Merged: 5/22/2020
Merged by: @undefined

Base: master ← Head: dev/migrie/b/3440-initialize-the-maximize-btn


📝 Commits (1)

  • 46e5196 Make sure to update the maximize button's visual state on launch

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+5 -0)

📄 Description

Summary of the Pull Request

This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state.

This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5988 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/19/2020 **Status:** ✅ Merged **Merged:** 5/22/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/3440-initialize-the-maximize-btn` --- ### 📝 Commits (1) - [`46e5196`](https://github.com/microsoft/terminal/commit/46e51966467b8fa345f6d59f4270f269294482d9) Make sure to update the maximize button's visual state on launch ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+5 -0) </details> ### 📄 Description ## Summary of the Pull Request This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state. This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree. ## PR Checklist * [x] Closes #3440 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:49 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26563