starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5999] [MERGED] Correct the default 6x6x6 palette entries #26565

New Issue
Open
opened 2026-01-31 09:16:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:50 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5999
Author: @j4james
Created: 5/19/2020
Status: ✅ Merged
Merged: 5/19/2020
Merged by: @undefined

Base: master ← Head: fix-default-palette

📝 Commits (3)

  • 1195ae7 Correct some of the values in the default 256-color palette.
  • 4c884ac Remove some unnecessary whitespace.
  • 98c43b2 Remove some more unnecessary whitespace.

📊 Changes

1 file changed (+134 additions, -134 deletions)

View changed files

📝 src/types/utils.cpp (+134 -134)

📄 Description

There is a range of 216 colors in the default 256-color table that is
meant to be initialized with a 6x6x6 color cube, with each color
component iterating over the values 00, 5F, 87, AF, D7, and
FF. A few of the entries incorrectly had the red component has DF,
when it should have been D7. This PR corrects those entries. It also
removes a bit of unnecessary whitespace in the first 100 entries.

Validation Steps Performed

I have a visual test script that renders the full 256-color palette,
using both the indexed color sequence (SGR 38;5) and the equivalent
rgb representation (SGR 38;2) side by side. Although the difference
was subtle when it was incorrect, I can now see that it has been fixed.

Closes #5994

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5999 **Author:** [@j4james](https://github.com/j4james) **Created:** 5/19/2020 **Status:** ✅ Merged **Merged:** 5/19/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `fix-default-palette` --- ### 📝 Commits (3) - [`1195ae7`](https://github.com/microsoft/terminal/commit/1195ae71cb58a6d863a40ee0b622212495ccef24) Correct some of the values in the default 256-color palette. - [`4c884ac`](https://github.com/microsoft/terminal/commit/4c884accac93eb9d8a144cb34a206b95f93b8fad) Remove some unnecessary whitespace. - [`98c43b2`](https://github.com/microsoft/terminal/commit/98c43b254e5200bb6b7a8797c3f8fe63ab00481a) Remove some more unnecessary whitespace. ### 📊 Changes **1 file changed** (+134 additions, -134 deletions) <details> <summary>View changed files</summary> 📝 `src/types/utils.cpp` (+134 -134) </details> ### 📄 Description There is a range of 216 colors in the default 256-color table that is meant to be initialized with a 6x6x6 color cube, with each color component iterating over the values `00`, `5F`, `87`, `AF`, `D7`, and `FF`. A few of the entries incorrectly had the _red_ component has `DF`, when it should have been `D7`. This PR corrects those entries. It also removes a bit of unnecessary whitespace in the first 100 entries. ## Validation Steps Performed I have a visual test script that renders the full 256-color palette, using both the indexed color sequence (`SGR 38;5`) and the equivalent rgb representation (`SGR 38;2`) side by side. Although the difference was subtle when it was incorrect, I can now see that it has been fixed. Closes #5994 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26565
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?