starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6048] [MERGED] Add font weight options #26571

New Issue
Open
opened 2026-01-31 09:16:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:16:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6048
Author: @miniksa
Created: 5/20/2020
Status: ✅ Merged
Merged: 5/20/2020
Merged by: @undefined

Base: master ← Head: dev/miniksa/font-weight

📝 Commits (8)

  • 236d129 Add font weight options to the settings and renderer.
  • 3669c20 Told you about tabs, bro.
  • c473945 PR comments. Be more specific in schema with enum and typeof. Consistency back and forth with the fact that names or values are valid. Change DirectWrite to OpenType because it's more generic of a term.
  • aea361a Drop serializer.
  • 4f187ac Use the winrt UI Text enum value as much as possible.
  • bb79b30 CODE FORMAT!!!! shakes fist at sky
  • 2db8dc4 Allow 100-990 for variable weight fonts.
  • 19963e9 CAST!

📊 Changes

13 files changed (+159 additions, -6 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -0)
📝 doc/cascadia/profiles.schema.json (+26 -0)
📝 src/cascadia/TerminalApp/Profile.cpp (+97 -0)
📝 src/cascadia/TerminalApp/Profile.h (+3 -0)
📝 src/cascadia/TerminalControl/TSFInputControl.cpp (+1 -0)
📝 src/cascadia/TerminalControl/TSFInputControl.h (+2 -0)
📝 src/cascadia/TerminalControl/TSFInputControl.idl (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+11 -5)
📝 src/cascadia/TerminalSettings/IControlSettings.idl (+1 -0)
📝 src/cascadia/TerminalSettings/TerminalSettings.cpp (+11 -0)
📝 src/cascadia/TerminalSettings/terminalsettings.h (+3 -0)
📝 src/inc/DefaultSettings.h (+1 -0)
📝 src/renderer/dx/DxRenderer.cpp (+1 -1)

📄 Description

Summary of the Pull Request

Adds the ability to specify the font weight in the profiles, right next to the size and the font face.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Cascadia Code normal
    image

  • Cascadia Code bold
    image

  • Segoe UI Semilight
    image

  • Segoe UI Black
    image

  • Segoe UI 900 (value for Black)
    image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6048 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 5/20/2020 **Status:** ✅ Merged **Merged:** 5/20/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/miniksa/font-weight` --- ### 📝 Commits (8) - [`236d129`](https://github.com/microsoft/terminal/commit/236d129437312286f170a2b29845f267f37f20cc) Add font weight options to the settings and renderer. - [`3669c20`](https://github.com/microsoft/terminal/commit/3669c2049e8532ea0666438ba007d9584a5e3969) Told you about tabs, bro. - [`c473945`](https://github.com/microsoft/terminal/commit/c4739452ff6ffc1ac831ff87b31e999e4041af75) PR comments. Be more specific in schema with enum and typeof. Consistency back and forth with the fact that names or values are valid. Change DirectWrite to OpenType because it's more generic of a term. - [`aea361a`](https://github.com/microsoft/terminal/commit/aea361a45e4a1ff13a601519280185457271806e) Drop serializer. - [`4f187ac`](https://github.com/microsoft/terminal/commit/4f187ac113483b4eee7c3fb65833d4bfba4ee847) Use the winrt UI Text enum value as much as possible. - [`bb79b30`](https://github.com/microsoft/terminal/commit/bb79b30919e34bb358c98e82aeb14e11c91eaef8) CODE FORMAT!!!! *shakes fist at sky* - [`2db8dc4`](https://github.com/microsoft/terminal/commit/2db8dc4b7d12ac82c99b6c7ffe4d06d823602aa4) Allow 100-990 for variable weight fonts. - [`19963e9`](https://github.com/microsoft/terminal/commit/19963e92f8ff991829c868569df9a1a539385f55) CAST! ### 📊 Changes **13 files changed** (+159 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -0) 📝 `doc/cascadia/profiles.schema.json` (+26 -0) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+97 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+3 -0) 📝 `src/cascadia/TerminalControl/TSFInputControl.cpp` (+1 -0) 📝 `src/cascadia/TerminalControl/TSFInputControl.h` (+2 -0) 📝 `src/cascadia/TerminalControl/TSFInputControl.idl` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+11 -5) 📝 `src/cascadia/TerminalSettings/IControlSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalSettings/TerminalSettings.cpp` (+11 -0) 📝 `src/cascadia/TerminalSettings/terminalsettings.h` (+3 -0) 📝 `src/inc/DefaultSettings.h` (+1 -0) 📝 `src/renderer/dx/DxRenderer.cpp` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request Adds the ability to specify the font weight in the profiles, right next to the size and the font face. ## PR Checklist * [x] Closes #1751 * [x] I work here. * [x] Tested manually, see below. * [x] Added documentation to the schema * [x] Requires docs.microsoft.com update, filed as https://github.com/MicrosoftDocs/terminal/issues/26 * [x] I'm a core contributor. ## Detailed Description of the Pull Request / Additional comments - Weights can be specified according to the OpenType specification values. We accept either the friendly name or the numerical value that applies to each weight. - Weights are carried through per-profile and sent into the renderer. - Weights are carried through to the TSF/IME overlay. - The names are restricted to the set seen at https://docs.microsoft.com/en-us/uwp/api/windows.ui.text.fontweights. - There are alternate names at https://docs.microsoft.com/en-us/windows/win32/api/dwrite/ne-dwrite-dwrite_font_weight for the same values (ultra-black is just an alias for extra-black at 950). ## Validation Steps Performed - Cascadia Code normal ![image](https://user-images.githubusercontent.com/18221333/82480181-46117380-9a88-11ea-9436-a5fe4ccd4350.png) - Cascadia Code bold ![image](https://user-images.githubusercontent.com/18221333/82480202-4f9adb80-9a88-11ea-9e27-a113b41387f5.png) - Segoe UI Semilight ![image](https://user-images.githubusercontent.com/18221333/82480306-73f6b800-9a88-11ea-93f7-d773ab7ccce8.png) - Segoe UI Black ![image](https://user-images.githubusercontent.com/18221333/82480401-9688d100-9a88-11ea-957c-0c8e03a8cc29.png) - Segoe UI 900 (value for Black) ![image](https://user-images.githubusercontent.com/18221333/82480774-26c71600-9a89-11ea-8cf6-aaeab1fd0747.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?