[PR #6060] [MERGED] Add support for fullscreen launchMode #26573

Open
opened 2026-01-31 09:16:54 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6060
Author: @zadjii-msft
Created: 5/20/2020
Status: ✅ Merged
Merged: 5/28/2020
Merged by: @undefined

Base: master ← Head: dev/migrie/f/288-launchMode-fullscreen


📝 Commits (8)

  • 46e5196 Make sure to update the maximize button's visual state on launch
  • 16e047f This works but the code is dirty, so I'll clean it up next
  • f1f4e44 Code cleanup for review
  • 9703212 Merge remote-tracking branch 'origin/master' into dev/migrie/f/288-launchMode-fullscreen
  • ac08b7c remove dead code
  • 6329bd6 Revert "Make sure to update the maximize button's visual state on launch"
  • 3b5d7c5 Merge remote-tracking branch 'origin/master' into dev/migrie/f/288-launchMode-fullscreen
  • 9aa4c1a fix up the vcxproj files

📊 Changes

7 files changed (+90 additions, -56 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppLogic.idl (+1 -0)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+7 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+26 -4)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+49 -51)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+1 -0)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+4 -1)

📄 Description

Summary of the Pull Request

Adds "launchMode": "fullscreen", which does what it says on the box.

PR Checklist

Detailed Description of the Pull Request / Additional comments

It's important to let the winow get created, then fullscreen it, because otherwise, when the user exits fullscreen, the window is sized to like, 0x0 or something, and that's just annoying.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6060 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/20/2020 **Status:** ✅ Merged **Merged:** 5/28/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/f/288-launchMode-fullscreen` --- ### 📝 Commits (8) - [`46e5196`](https://github.com/microsoft/terminal/commit/46e51966467b8fa345f6d59f4270f269294482d9) Make sure to update the maximize button's visual state on launch - [`16e047f`](https://github.com/microsoft/terminal/commit/16e047f41e7aa5999c63af2d591a62d066b27473) This works but the code is dirty, so I'll clean it up next - [`f1f4e44`](https://github.com/microsoft/terminal/commit/f1f4e44e7acd3ef6cb4be1346854bb2911592683) Code cleanup for review - [`9703212`](https://github.com/microsoft/terminal/commit/97032122be9038047395940eb5295ba0b9e4f43f) Merge remote-tracking branch 'origin/master' into dev/migrie/f/288-launchMode-fullscreen - [`ac08b7c`](https://github.com/microsoft/terminal/commit/ac08b7c95486747437d1ba1d43ade737d025013c) remove dead code - [`6329bd6`](https://github.com/microsoft/terminal/commit/6329bd6923b5e35db8b1d015d0fa70da9a614b68) Revert "Make sure to update the maximize button's visual state on launch" - [`3b5d7c5`](https://github.com/microsoft/terminal/commit/3b5d7c55700d1865ebaf8d8eede73ef66f9c9838) Merge remote-tracking branch 'origin/master' into dev/migrie/f/288-launchMode-fullscreen - [`9aa4c1a`](https://github.com/microsoft/terminal/commit/9aa4c1aeabc70690553f681baccf4779495c81a0) fix up the vcxproj files ### 📊 Changes **7 files changed** (+90 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+1 -0) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+7 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+26 -4) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+49 -51) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+1 -0) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+4 -1) </details> ### 📄 Description ## Summary of the Pull Request Adds `"launchMode": "fullscreen"`, which does what it says on the box. ## PR Checklist * [x] Closes #288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments It's important to let the winow get created, _then_ fullscreen it, because otherwise, when the user exits fullscreen, the window is sized to like, 0x0 or something, and that's just annoying. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:54 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26573