[PR #6110] [MERGED] Replace everything in TerminalSettings with GETSET_PROPERTY #26582

Open
opened 2026-01-31 09:16:58 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6110
Author: @zadjii-msft
Created: 5/21/2020
Status: Merged
Merged: 5/27/2020
Merged by: @undefined

Base: masterHead: dev/migrie/f/just-delete-it-all


📝 Commits (2)

  • aea4327 Just replace everything with GETSET_PROPERTY
  • e34e416 I guess just suppress this warning

📊 Changes

3 files changed (+69 additions, -514 deletions)

View changed files

📝 src/cascadia/TerminalSettings/TerminalSettings.cpp (+0 -390)
📝 src/cascadia/TerminalSettings/terminalsettings.h (+63 -118)
📝 src/cascadia/inc/cppwinrt_utils.h (+6 -6)

📄 Description

This is mostly a codehealth thing - we made these handy macros for just defining basic { get; set; } properties, but we never used them in TerminalSettings, because that file was written before the macros were.

This cleans up that class.

  • I work here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6110 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/21/2020 **Status:** ✅ Merged **Merged:** 5/27/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/f/just-delete-it-all` --- ### 📝 Commits (2) - [`aea4327`](https://github.com/microsoft/terminal/commit/aea432712b52894d0448845b857371d3fd7df3e3) Just replace everything with GETSET_PROPERTY - [`e34e416`](https://github.com/microsoft/terminal/commit/e34e4164f96951a55ee92a047d671f0a1964bb05) I guess just suppress this warning ### 📊 Changes **3 files changed** (+69 additions, -514 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettings/TerminalSettings.cpp` (+0 -390) 📝 `src/cascadia/TerminalSettings/terminalsettings.h` (+63 -118) 📝 `src/cascadia/inc/cppwinrt_utils.h` (+6 -6) </details> ### 📄 Description This is mostly a codehealth thing - we made these handy macros for just defining basic `{ get; set; }` properties, but we never used them in TerminalSettings, because that file was written before the macros were. This cleans up that class. * [x] I work here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:16:58 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26582