starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6226] [MERGED] Add stdexcept header explicitly to u8u16test tool #26601

New Issue
Open
opened 2026-01-31 09:17:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:17:05 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6226
Author: @miniksa
Created: 5/27/2020
Status: ✅ Merged
Merged: 5/27/2020
Merged by: @miniksa

Base: master ← Head: dev/miniksa/stl_changed

📝 Commits (1)

  • 5760e7e Add stdexcept header explicitly to u8u16test tool because it was implicitly included in STL 16.5 but no longer in STL 16.6.

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/tools/U8U16Test/U8U16Test.hpp (+1 -0)

📄 Description

Summary of the Pull Request

Adds implicit stdexcept header include to u8u16test tool.

PR Checklist

  • Closes regression introduced when moving from VS 16.5 to VS 16.6 (which the CI did of its own accord)
  • I work here.
  • Built it.
  • No doc.
  • Am core contributor.

Detailed Description of the Pull Request / Additional comments

In VS 16.5, the header was pulled in by <string> or <string_view> or <array> or <algorithm> implicitly. In VS 16.6, that's gone. No one wrote it in the header because it was just automatically there in the past. Now I wrote it in the header.

Validation Steps Performed

  • Built it on my machine after upgrading to VS 16.6.0.
  • Built it in CI.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6226 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 5/27/2020 **Status:** ✅ Merged **Merged:** 5/27/2020 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `dev/miniksa/stl_changed` --- ### 📝 Commits (1) - [`5760e7e`](https://github.com/microsoft/terminal/commit/5760e7ed6067ea29383a86902ee823aae583b45b) Add stdexcept header explicitly to u8u16test tool because it was implicitly included in STL 16.5 but no longer in STL 16.6. ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/tools/U8U16Test/U8U16Test.hpp` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds implicit stdexcept header include to u8u16test tool. ## PR Checklist * [x] Closes regression introduced when moving from VS 16.5 to VS 16.6 (which the CI did of its own accord) * [x] I work here. * [x] Built it. * [x] No doc. * [x] Am core contributor. ## Detailed Description of the Pull Request / Additional comments In VS 16.5, the <stdexcept> header was pulled in by `<string>` or `<string_view>` or `<array>` or `<algorithm>` implicitly. In VS 16.6, that's gone. No one wrote it in the header because it was just automatically there in the past. Now I wrote it in the header. ## Validation Steps Performed * [x] Built it on my machine after upgrading to VS `16.6.0`. * [ ] Built it in CI. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26601
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?