[PR #6220] [CLOSED] Fix the u8u16 test project? #26604

Open
opened 2026-01-31 09:17:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6220
Author: @zadjii-msft
Created: 5/27/2020
Status: Closed

Base: masterHead: dev/migrie/b/fix-the-build-i-guess


📝 Commits (1)

  • 08701f2 I have no idea when this regressed

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/tools/U8U16Test/U8U16Test.hpp (+1 -0)

📄 Description

I have no idea what's going on here.

I have a build failure that happened over in #6100 https://dev.azure.com/ms/Terminal/_build/results?buildId=83368&view=logs&jobId=6e3e7df0-e6f0-5f0c-c8d6-63e192049bc0

It looks like there's a missing header from the U8U16Test project, which I haven't touched at all.

Trying to build that locally on master, I get the same error.

This header looks like it's the missing one. All I can find about it is this obscure forum post. So I have no idea what's really going on here, but this should fix the build?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6220 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/27/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/migrie/b/fix-the-build-i-guess` --- ### 📝 Commits (1) - [`08701f2`](https://github.com/microsoft/terminal/commit/08701f26b8c2a622477b72256b1bd0df45c14cfd) I have no idea when this regressed ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/tools/U8U16Test/U8U16Test.hpp` (+1 -0) </details> ### 📄 Description I have no idea what's going on here. I have a build failure that happened over in #6100 https://dev.azure.com/ms/Terminal/_build/results?buildId=83368&view=logs&jobId=6e3e7df0-e6f0-5f0c-c8d6-63e192049bc0 It _looks_ like there's a missing header from the `U8U16Test` project, which I haven't touched at all. Trying to build that locally on master, **I get the same error**. This header looks like it's the missing one. All I can find about it is [this obscure forum post](https://forum.zdoom.org/viewtopic.php?f=7&t=68641). So I have no idea what's really going on here, but this should fix the build? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26604