[PR #6238] [MERGED] Make the Shell Extension methods STDMETHODIMP #26611

Open
opened 2026-01-31 09:17:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6238
Author: @zadjii-msft
Created: 5/28/2020
Status: Merged
Merged: 5/28/2020
Merged by: @DHowett

Base: masterHead: dev/migrie/b/STDMETHODIMP


📝 Commits (1)

📊 Changes

1 file changed (+14 additions, -14 deletions)

View changed files

📝 src/cascadia/ShellExtension/OpenTerminalHere.h (+14 -14)

📄 Description

These methods need to be declared STDMETHODIMP so the x86 build will pass.

  • I work here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6238 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/28/2020 **Status:** ✅ Merged **Merged:** 5/28/2020 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `master` ← **Head:** `dev/migrie/b/STDMETHODIMP` --- ### 📝 Commits (1) - [`2151ec1`](https://github.com/microsoft/terminal/commit/2151ec1977d0bc64eda04f07cd24ba5136336e21) x86 is hard ### 📊 Changes **1 file changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/ShellExtension/OpenTerminalHere.h` (+14 -14) </details> ### 📄 Description These methods need to be declared `STDMETHODIMP` so the x86 build will pass. * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26611