[PR #6229] [MERGED] Update wil. Fixes GDI handle leak #26614

Open
opened 2026-01-31 09:17:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6229
Author: @miniksa
Created: 5/27/2020
Status: ✅ Merged
Merged: 6/1/2020
Merged by: @undefined

Base: master ← Head: dev/miniksa/wil


📝 Commits (4)

📊 Changes

8 files changed (+15 additions, -4 deletions)

View changed files

➕ .github/actions/spell-check/dictionary/api.txt (+0 -0)
📝 .github/actions/spell-check/dictionary/apis.txt (+1 -0)
📝 dep/wil (+1 -1)
📝 src/buffer/out/CharRow.cpp (+1 -1)
📝 src/buffer/out/CharRow.hpp (+1 -1)
📝 src/cascadia/PublicTerminalCore/HwndTerminal.cpp (+5 -1)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+4 -0)
📝 src/renderer/dx/DxRenderer.cpp (+2 -0)

📄 Description

Summary of the Pull Request

When resizing the window title, a GDI object would be leaked. This has to do with our island message handler using wil to track these objects and wil having a bug.

References

microsoft/wil#100

PR Checklist

Validation Steps Performed

  • Added the GDI Objects column to Task Manager, set the Terminal to use the titleWidth size tabs, then changed the title a bunch with PowerShell. Confirmed repro before (increasing GDI count). Confirmed it's gone after (no change to object count).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6229 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 5/27/2020 **Status:** ✅ Merged **Merged:** 6/1/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/miniksa/wil` --- ### 📝 Commits (4) - [`0e043f4`](https://github.com/microsoft/terminal/commit/0e043f4e5ab93f6639772f00b9767317e0c4e9f2) Update wil. Fixes #5949 - [`b8258b2`](https://github.com/microsoft/terminal/commit/b8258b271197ddc980ce50f8d5b76c40cb21bf58) Add IStorage to api list. - [`970fd67`](https://github.com/microsoft/terminal/commit/970fd67fd214c68e874b3f2c1b5766ea8da8862f) Add try/catches around places with noexcept conflicts thanks to updated wil. - [`b59d8a8`](https://github.com/microsoft/terminal/commit/b59d8a819f80104fc4a08c0685bbe1c42d5267f6) drop extra noexcept ### 📊 Changes **8 files changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/spell-check/dictionary/api.txt` (+0 -0) 📝 `.github/actions/spell-check/dictionary/apis.txt` (+1 -0) 📝 `dep/wil` (+1 -1) 📝 `src/buffer/out/CharRow.cpp` (+1 -1) 📝 `src/buffer/out/CharRow.hpp` (+1 -1) 📝 `src/cascadia/PublicTerminalCore/HwndTerminal.cpp` (+5 -1) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+4 -0) 📝 `src/renderer/dx/DxRenderer.cpp` (+2 -0) </details> ### 📄 Description ## Summary of the Pull Request When resizing the window title, a GDI object would be leaked. This has to do with our island message handler using `wil` to track these objects and `wil` having a bug. ## References microsoft/wil#100 ## PR Checklist * [x] Closes #5949 * [x] I work here. * [x] Tested manually * [x] Doc not required. * [x] Am core contributor. ## Validation Steps Performed * [x] Added the GDI Objects column to Task Manager, set the Terminal to use the `titleWidth` size tabs, then changed the title a bunch with PowerShell. Confirmed repro before (increasing GDI count). Confirmed it's gone after (no change to object count). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26614