starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6290] [CLOSED] When the tab receives focus, immediately move focus to the active control #26621

New Issue
Open
opened 2026-01-31 09:17:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:17:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6290
Author: @zadjii-msft
Created: 6/1/2020
Status: ❌ Closed

Base: main ← Head: dev/migrie/b/moving-focus-is-hard

📝 Commits (2)

  • aa2fe26 Try moving focus to the control when the tab itself gains focus. This doesn't work when the unfocused tab is renamed, and might do weird things with accessibility
  • 548dd0e This is better

📊 Changes

3 files changed (+38 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/Tab.cpp (+26 -0)
📝 src/cascadia/TerminalApp/Tab.h (+1 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+11 -0)

📄 Description

I'm mostly just putting the PR out there for comments. I'm worried that this might have horrifying unintentional side-effects for accessibility, which I'm not loving.

This PR makes the Tab immediately toss focus to the active control, whenever the Tab receives focus, for any reason.

  • Left-click on the tab to focus the window? Focus the control. #3609
  • Close the color picker? Focus the control.
  • Hit esc to dismiss the menuflyout from the New Tab menu, the tab context menu? Focus the control. #5750
  • Hit esc to dismiss the tab rename? Focus the control.

@carlos-zamora will this horribly break accessibility?

My other theory here is to pre-emptively prevent the tab from receiving focus. That would probably involve

  • Focusing the control when a tab is left clicked
  • Manually passing focus to the control when any flyout is closed
  • Manually passing focus to the control when the color picker is closed
  • Manually passing focus to the control when the tab renamer is dismissed
  • Manually passing focus to the control when the command palette is closed
  • Manually passing focus to the control when <any future UI> is closed

So that might not scale as well, but that might be the more correct solution.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6290 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/1/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/migrie/b/moving-focus-is-hard` --- ### 📝 Commits (2) - [`aa2fe26`](https://github.com/microsoft/terminal/commit/aa2fe262a194c8946d2434bdae74edb7a256eaf9) Try moving focus to the control when the tab itself gains focus. This doesn't work when the unfocused tab is renamed, and might do weird things with accessibility - [`548dd0e`](https://github.com/microsoft/terminal/commit/548dd0ea92c0824fb2b2b29e4214654fdd1ac6f6) This is better ### 📊 Changes **3 files changed** (+38 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Tab.cpp` (+26 -0) 📝 `src/cascadia/TerminalApp/Tab.h` (+1 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+11 -0) </details> ### 📄 Description I'm mostly just putting the PR out there for comments. I'm worried that this might have horrifying unintentional side-effects for accessibility, which I'm not loving. This PR makes the `Tab` immediately toss focus to the active control, whenever the `Tab` receives focus, for any reason. * Left-click on the tab to focus the window? Focus the control. #3609 * Close the color picker? Focus the control. * Hit esc to dismiss the menuflyout from the New Tab menu, the tab context menu? Focus the control. #5750 * Hit esc to dismiss the tab rename? Focus the control. @carlos-zamora will this horribly break accessibility? My other theory here is to pre-emptively prevent the tab from receiving focus. That would probably involve * Focusing the control when a tab is left clicked * Manually passing focus to the control when any flyout is closed * Manually passing focus to the control when the color picker is closed * Manually passing focus to the control when the tab renamer is dismissed * Manually passing focus to the control when the command palette is closed * Manually passing focus to the control when \<any future UI> is closed So that might not scale as well, but that might be the more _correct_ solution. * [x] I work here * [ ] This is UI so it doesn't have tests * [x] Closes #3609 * [x] Closes #5750 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?