starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6299] [MERGED] Add keybinding arg to openSettings #26631

New Issue
Open
opened 2026-01-31 09:17:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:17:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6299
Author: @carlos-zamora
Created: 6/1/2020
Status: ✅ Merged
Merged: 6/12/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/settings-kbd

📝 Commits (5)

  • e959373 Add keybinding arg to openSettings
  • 1c4db02 update AppKeyBindingsSerialization
  • 38e4426 remove default param
  • 0f0ef42 some of Dustin's comments
  • 3deb606 Ref filePath in lambda

📊 Changes

9 files changed (+131 additions, -12 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+27 -0)
📝 src/cascadia/TerminalApp/ActionArgs.cpp (+1 -0)
📝 src/cascadia/TerminalApp/ActionArgs.h (+60 -0)
📝 src/cascadia/TerminalApp/ActionArgs.idl (+12 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+5 -3)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+22 -8)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)
📝 src/cascadia/TerminalApp/defaults.json (+1 -0)

📄 Description

Summary of the Pull Request

Adds the target keybinding arg to openSettings. Possible values include: defaultsFile, settingsFile, and allFiles.

References

#5915 - mini-spec

PR Checklist

Detailed Description of the Pull Request / Additional comments

Implemented as discussed in the attached spec. A new enum will be added for the SettingsUI when it becomes available.

Validation Steps Performed

Added the following to my settings.json:

{ "command": "openSettings", "keys":... },
{ "command": { "action": "openSettings" }, "keys":... },
{ "command": { "action": "openSettings", "target": "settingsFile" }, "keys":... },
{ "command": { "action": "openSettings", "target": "defaultsFile" }, "keys":... },
{ "command": { "action": "openSettings", "target": "allFiles" }, "keys":... }

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6299 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 6/1/2020 **Status:** ✅ Merged **Merged:** 6/12/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/settings-kbd` --- ### 📝 Commits (5) - [`e959373`](https://github.com/microsoft/terminal/commit/e9593737f58f96af010820fed6d965cc705fbd01) Add keybinding arg to openSettings - [`1c4db02`](https://github.com/microsoft/terminal/commit/1c4db020a29f72d3d36f01384454bfba813feb88) update AppKeyBindingsSerialization - [`38e4426`](https://github.com/microsoft/terminal/commit/38e4426c25469f3e8abecd125ef837d41bc581d4) remove default param - [`0f0ef42`](https://github.com/microsoft/terminal/commit/0f0ef42456c74689a1e1624443aeb60cca40ca71) some of Dustin's comments - [`3deb606`](https://github.com/microsoft/terminal/commit/3deb60628e3f0cd3c3d162241e9eda8439e44c5f) Ref filePath in lambda ### 📊 Changes **9 files changed** (+131 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+27 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.cpp` (+1 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+60 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.idl` (+12 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+5 -3) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+22 -8) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) 📝 `src/cascadia/TerminalApp/defaults.json` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds the `target` keybinding arg to `openSettings`. Possible values include: `defaultsFile`, `settingsFile`, and `allFiles`. ## References #5915 - mini-spec ## PR Checklist * [x] Closes #2557 * [x] Tests added/passed ## Detailed Description of the Pull Request / Additional comments Implemented as discussed in the attached spec. A new enum will be added for the SettingsUI when it becomes available. ## Validation Steps Performed Added the following to my settings.json: ```json { "command": "openSettings", "keys":... }, { "command": { "action": "openSettings" }, "keys":... }, { "command": { "action": "openSettings", "target": "settingsFile" }, "keys":... }, { "command": { "action": "openSettings", "target": "defaultsFile" }, "keys":... }, { "command": { "action": "openSettings", "target": "allFiles" }, "keys":... } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26631
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?