[PR #6312] [MERGED] Add a test to ensure support for trailing commas in settings.json #26639

Open
opened 2026-01-31 09:17:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6312
Author: @zadjii-msft
Created: 6/2/2020
Status: Merged
Merged: 6/4/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/trailing-commas


📝 Commits (4)

  • 4649a45 Update jsoncpp to 1.9.3
  • 667b266 Add support for trailing commas in the settings.json file
  • 54ca186 Merge remote-tracking branch 'origin/master' into dev/migrie/b/trailing-commas
  • 471257b well hey we didn't need this after all

📊 Changes

1 file changed (+37 additions, -0 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+37 -0)

📄 Description

Summary of the Pull Request

Adds support for trailing commas in our json files.

References

PR Checklist

  • I work here
  • Tests added/passed
  • [n/a] Requires documentation to be updated

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6312 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/2/2020 **Status:** ✅ Merged **Merged:** 6/4/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/trailing-commas` --- ### 📝 Commits (4) - [`4649a45`](https://github.com/microsoft/terminal/commit/4649a45903e9554f71566e436ce3df04dc374618) Update jsoncpp to 1.9.3 - [`667b266`](https://github.com/microsoft/terminal/commit/667b26635b0c4ce1f69c59c5d4bf86842813c4aa) Add support for trailing commas in the settings.json file - [`54ca186`](https://github.com/microsoft/terminal/commit/54ca1863e1dc8d52374503c47a89558748d00ff8) Merge remote-tracking branch 'origin/master' into dev/migrie/b/trailing-commas - [`471257b`](https://github.com/microsoft/terminal/commit/471257b48d7ca0bf4572fb99e573d25da6974f9c) well hey we didn't need this after all ### 📊 Changes **1 file changed** (+37 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+37 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds support for trailing commas in our json files. ## References * Enabled due to the excellent work over in https://github.com/open-source-parsers/jsoncpp/pull/1098 ## PR Checklist * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26639