[PR #6351] [MERGED] Extract ActionAndArgs::FromJson into its own class #26652

Open
opened 2026-01-31 09:17:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6351
Author: @zadjii-msft
Created: 6/4/2020
Status: ✅ Merged
Merged: 6/15/2020
Merged by: @undefined

Base: master ← Head: dev/migrie/f/extract-ActionAndArgs-FromJson


📝 Commits (5)

  • 6e6979a Extract ActionAndArgs::FromJson into it's own class, so it can be re-used later
  • 22f86d3 Merge remote-tracking branch 'origin/master' into dev/migrie/f/extract-ActionAndArgs-FromJson
  • 746aeab Merge remote-tracking branch 'origin/master' into dev/migrie/f/extract-ActionAndArgs-FromJson
  • 0815d4e Remove outdated comment
  • d2cfea3 Merge remote-tracking branch 'origin/master' into dev/migrie/f/extract-ActionAndArgs-FromJson

📊 Changes

3 files changed (+218 additions, -174 deletions)

View changed files

📝 src/cascadia/TerminalApp/ActionAndArgs.cpp (+204 -3)
📝 src/cascadia/TerminalApp/ActionAndArgs.h (+5 -0)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+9 -171)

📄 Description

Summary of the Pull Request

Pulls the ActionAndArgs deserializing into its own class, separate from AppKeyBindings. Some 2.0 features are going to need to re-use these actions in their json, so we'll want one unified way of deserializing them.

References

  • Done primarily as part of the work on #2046/#5400/#5674
  • Also related: #1571/#5888
  • Will aggressively conflict with any open PRs that introduced keybindings (looking at #6299)

PR Checklist

  • Closes nothing, this is code refactoring
  • I work here
  • Current tests passed
  • [n/a] Requires documentation to be updated

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6351 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/4/2020 **Status:** ✅ Merged **Merged:** 6/15/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/f/extract-ActionAndArgs-FromJson` --- ### 📝 Commits (5) - [`6e6979a`](https://github.com/microsoft/terminal/commit/6e6979abe813f6105b8aade8a071eb6e03640b3b) Extract ActionAndArgs::FromJson into it's own class, so it can be re-used later - [`22f86d3`](https://github.com/microsoft/terminal/commit/22f86d318dbdf87a784a538a4dbab6e3d155ebb3) Merge remote-tracking branch 'origin/master' into dev/migrie/f/extract-ActionAndArgs-FromJson - [`746aeab`](https://github.com/microsoft/terminal/commit/746aeabb7ed1198b011fcdd52fdc224f5a4d31ee) Merge remote-tracking branch 'origin/master' into dev/migrie/f/extract-ActionAndArgs-FromJson - [`0815d4e`](https://github.com/microsoft/terminal/commit/0815d4eb62936de0323b74c316353e6eb89b9d38) Remove outdated comment - [`d2cfea3`](https://github.com/microsoft/terminal/commit/d2cfea3010d2d29788798aab4f88c628467b29aa) Merge remote-tracking branch 'origin/master' into dev/migrie/f/extract-ActionAndArgs-FromJson ### 📊 Changes **3 files changed** (+218 additions, -174 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/ActionAndArgs.cpp` (+204 -3) 📝 `src/cascadia/TerminalApp/ActionAndArgs.h` (+5 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+9 -171) </details> ### 📄 Description ## Summary of the Pull Request Pulls the `ActionAndArgs` deserializing into its own class, separate from `AppKeyBindings`. Some 2.0 features are going to need to re-use these actions in their json, so we'll want one unified way of deserializing them. ## References * Done primarily as part of the work on #2046/#5400/#5674 * Also related: #1571/#5888 * Will aggressively conflict with any open PRs that introduced keybindings (looking at #6299) ## PR Checklist * [x] Closes nothing, this is code refactoring * [x] I work here * [x] Current tests passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:22 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26652