starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6433] [MERGED] Set tab title as early as possible #26679

New Issue
Open
opened 2026-01-31 09:17:31 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:17:31 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6433
Author: @beviu
Created: 6/9/2020
Status: ✅ Merged
Merged: 6/9/2020
Merged by: @undefined

Base: master ← Head: set-title-early

📝 Commits (1)

📊 Changes

6 files changed (+20 additions, -14 deletions)

View changed files

📝 src/cascadia/TerminalApp/Tab.cpp (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+2 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+6 -8)
📝 src/cascadia/TerminalCore/Terminal.hpp (+1 -1)
📝 src/cascadia/TerminalCore/TerminalApi.cpp (+5 -4)
📝 src/cascadia/TerminalCore/terminalrenderdata.cpp (+5 -1)

📄 Description

When opening a new tab, it takes a few milliseconds before title to
appears. This PR makes it instantaneous.

  • Updated the Terminal so that it can load the title from the settings
    before it is initialized.
  • Load terminal settings in TermControl constructor before the terminal
    is initialized (see above).
  • Update Tab so that it sets the TabViewItem's title in the constructor
    (in Tab::_MakeTabViewItem) instead of waiting for the VT sequence to
    set the title (from what I understand).

NOTE 1: there is a similar problem with the tabview icon which is not
fixed by this PR.

NOTE 2: This is only a problem with animations disabled because
otherwise the title fades in so there is enough time for it to be set
when it becomes visible.

Validation

I ran the terminal and opened a new tab. The title appears instantly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6433 **Author:** [@beviu](https://github.com/beviu) **Created:** 6/9/2020 **Status:** ✅ Merged **Merged:** 6/9/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `set-title-early` --- ### 📝 Commits (1) - [`adb39a0`](https://github.com/microsoft/terminal/commit/adb39a0cc11813aa2a3ed7818d50637feb71273a) Set tab title early ### 📊 Changes **6 files changed** (+20 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Tab.cpp` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+2 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+6 -8) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+1 -1) 📝 `src/cascadia/TerminalCore/TerminalApi.cpp` (+5 -4) 📝 `src/cascadia/TerminalCore/terminalrenderdata.cpp` (+5 -1) </details> ### 📄 Description When opening a new tab, it takes a few milliseconds before title to appears. This PR makes it instantaneous. * Updated the Terminal so that it can load the title from the settings before it is initialized. * Load terminal settings in TermControl constructor before the terminal is initialized (see above). * Update Tab so that it sets the TabViewItem's title in the constructor (in Tab::_MakeTabViewItem) instead of waiting for the VT sequence to set the title (from what I understand). NOTE 1: there is a similar problem with the tabview icon which is not fixed by this PR. NOTE 2: This is only a problem with animations disabled because otherwise the title fades in so there is enough time for it to be set when it becomes visible. ## Validation I ran the terminal and opened a new tab. The title appears instantly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26679
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?