starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6464] [MERGED] Fix 3 different bugs in the WPF control #26692

New Issue
Open
opened 2026-01-31 09:17:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:17:35 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6464
Author: @zadjii-msft
Created: 6/11/2020
Status: ✅ Merged
Merged: 6/11/2020
Merged by: @undefined

Base: master ← Head: dev/migrie/b/wpf-control-fixes

📝 Commits (1)

  • b3b2d9b Fix like 3 different bugs in the WPF control

📊 Changes

4 files changed (+38 additions, -16 deletions)

View changed files

📝 src/cascadia/WpfTerminalControl/TerminalContainer.cs (+17 -8)
📝 src/cascadia/WpfTerminalTestNetCore/WpfTerminalTestNetCore/MainWindow.xaml.cs (+16 -3)
📝 src/renderer/dx/CustomTextRenderer.cpp (+1 -1)
📝 src/renderer/dx/CustomTextRenderer.h (+4 -4)

📄 Description

  • [wpf] WM_KEYUP crashes on x64 #6444

    • Turns out that doing the (uint)lParam cast worked fine for the
      keydowns, because the value of lParam usually didn't have super
      high-order bits set. That's not the case for keyups, where the 30th
      bit is always set. This is fixed by explicitly getting the byte
      with the scancode in it.

  • [wpf] WM_KEYUP generates wrong value in Win32 input mode #6445

    • This was fixed by basically the same thing as the above.

  • [wpf] WPF control crashes on startup trying to render cursor #6446

    • This was a regression from #6337. I forgot to initialize the brush
      used to paint the cursor, because the UWP version always uses color
      (but the WPF one relies on the text foreground color).

  • Also adds a minor change to the WPF test app, so that the user can
    actually exit win32-input-mode.

  • #6337 regressed #6446

  • #6309 regressed the other two.

Closes #6444
Closes #6445
Closes #6446

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6464 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/11/2020 **Status:** ✅ Merged **Merged:** 6/11/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/wpf-control-fixes` --- ### 📝 Commits (1) - [`b3b2d9b`](https://github.com/microsoft/terminal/commit/b3b2d9bda665e0d9f494c1bee596ec0fce6d76a7) Fix like 3 different bugs in the WPF control ### 📊 Changes **4 files changed** (+38 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WpfTerminalControl/TerminalContainer.cs` (+17 -8) 📝 `src/cascadia/WpfTerminalTestNetCore/WpfTerminalTestNetCore/MainWindow.xaml.cs` (+16 -3) 📝 `src/renderer/dx/CustomTextRenderer.cpp` (+1 -1) 📝 `src/renderer/dx/CustomTextRenderer.h` (+4 -4) </details> ### 📄 Description * [wpf] WM_KEYUP crashes on x64 #6444 - Turns out that doing the `(uint)lParam` cast worked fine for the keydowns, because the value of lParam usually didn't have super high-order bits set. That's not the case for keyups, where the 30th bit is _always_ set. This is fixed by explicitly getting the byte with the scancode in it. * [wpf] WM_KEYUP generates wrong value in Win32 input mode #6445 - This was fixed by basically the same thing as the above. * [wpf] WPF control crashes on startup trying to render cursor #6446 - This was a regression from #6337. I forgot to initialize the brush used to paint the cursor, because the UWP version always uses color (but the WPF one relies on the text foreground color). * Also adds a minor change to the WPF test app, so that the user can actually exit `win32-input-mode`. * #6337 regressed #6446 * #6309 regressed the other two. Closes #6444 Closes #6445 Closes #6446 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26692
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?