[PR #6526] [MERGED] Remove the WinTelnetEngine #26719

Open
opened 2026-01-31 09:17:44 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6526
Author: @DHowett
Created: 6/15/2020
Status: Merged
Merged: 6/17/2020
Merged by: @undefined

Base: masterHead: dev/duhowett/lose_telnet


📝 Commits (1)

  • 0cf9f0b Remove the WinTelnetEngine

📊 Changes

11 files changed (+2 additions, -470 deletions)

View changed files

📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+0 -1)
📝 src/host/VtIo.cpp (+0 -11)
📝 src/host/ut_host/ConptyOutputTests.cpp (+0 -1)
📝 src/host/ut_host/ConsoleArgumentsTests.cpp (+2 -2)
📝 src/host/ut_host/VtIoTests.cpp (+0 -38)
📝 src/host/ut_host/VtRendererTests.cpp (+0 -235)
📝 src/inc/VtIoModes.hpp (+0 -2)
src/renderer/vt/WinTelnetEngine.cpp (+0 -124)
src/renderer/vt/WinTelnetEngine.hpp (+0 -53)
📝 src/renderer/vt/sources.inc (+0 -1)
📝 src/renderer/vt/vt-renderer-common.vcxitems (+0 -2)

📄 Description

Nobody was using it.

Discussed in #2661.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6526 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 6/15/2020 **Status:** ✅ Merged **Merged:** 6/17/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/duhowett/lose_telnet` --- ### 📝 Commits (1) - [`0cf9f0b`](https://github.com/microsoft/terminal/commit/0cf9f0b7a2e97d0285d6684d56dab088a9b03e59) Remove the WinTelnetEngine ### 📊 Changes **11 files changed** (+2 additions, -470 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+0 -1) 📝 `src/host/VtIo.cpp` (+0 -11) 📝 `src/host/ut_host/ConptyOutputTests.cpp` (+0 -1) 📝 `src/host/ut_host/ConsoleArgumentsTests.cpp` (+2 -2) 📝 `src/host/ut_host/VtIoTests.cpp` (+0 -38) 📝 `src/host/ut_host/VtRendererTests.cpp` (+0 -235) 📝 `src/inc/VtIoModes.hpp` (+0 -2) ➖ `src/renderer/vt/WinTelnetEngine.cpp` (+0 -124) ➖ `src/renderer/vt/WinTelnetEngine.hpp` (+0 -53) 📝 `src/renderer/vt/sources.inc` (+0 -1) 📝 `src/renderer/vt/vt-renderer-common.vcxitems` (+0 -2) </details> ### 📄 Description Nobody was using it. Discussed in #2661. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:44 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26719