[PR #6517] [MERGED] Only snap on key _downs_ #26722

Open
opened 2026-01-31 09:17:45 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6517
Author: @zadjii-msft
Created: 6/15/2020
Status: ✅ Merged
Merged: 6/15/2020
Merged by: @undefined

Base: master ← Head: dev/migrie/b/6481-i-guess-only-snap-on-chars


📝 Commits (2)

  • 9f3c5d6 Only snap on characters and some special keys
  • e0675df this is much simpler

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalCore/Terminal.cpp (+3 -1)

📄 Description

Summary of the Pull Request

Prior to #6309, we'd only snap on input for non-modifier key_down_ events. #6423 fixed this for modifier keys, but didn't fix this for keyups.

References

  • #6423 was an incomplete fix to this problem, which caused this regression

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6517 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/15/2020 **Status:** ✅ Merged **Merged:** 6/15/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/6481-i-guess-only-snap-on-chars` --- ### 📝 Commits (2) - [`9f3c5d6`](https://github.com/microsoft/terminal/commit/9f3c5d6cf08bbe879d748535a8ae0ff6943aaf73) Only snap on characters and some special keys - [`e0675df`](https://github.com/microsoft/terminal/commit/e0675dfd254e2f72be1aa8af27e0b22ba5f7aff4) this is much simpler ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+3 -1) </details> ### 📄 Description ## Summary of the Pull Request Prior to #6309, we'd only snap on input for non-modifier key_down_ events. #6423 fixed this for modifier keys, but didn't fix this for keyups. ## References * #6423 was an incomplete fix to this problem, which caused this regression ## PR Checklist * [x] Closes #6481 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:45 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26722