[PR #6552] [CLOSED] Add option to strip tabs on paste #26733

Open
opened 2026-01-31 09:17:49 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6552
Author: @ggadget6
Created: 6/17/2020
Status: ❌ Closed

Base: master ← Head: tabParse


📝 Commits (5)

  • 6f5d103 initial dirty implementation of tab stripping
  • 2990ecc Resolve issue with std::remove's return value
  • 32805e4 Make removing tabs on paste an option
  • f5a30c5 Address weakThis concerns for RemoveTabsOnPaste() and remove raw new and delete statements.
  • 80719d0 Add ReplaceTabsWithSpacesOnPaste with optional int value to replace RemoveTabsOnPaste as an option in PasteFromClipBoard. Add GetOptionalInt() to JsonUtils.

📊 Changes

6 files changed (+57 additions, -8 deletions)

View changed files

📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+3 -0)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+1 -0)
📝 src/cascadia/TerminalApp/JsonUtils.cpp (+17 -0)
📝 src/cascadia/TerminalApp/JsonUtils.h (+4 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+31 -7)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)

📄 Description

Summary of the Pull Request

Add option to remove tabs that are pasted in (similar to cmd)

References

None, as far as I know

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

I built and loaded the terminal and disabled and enabled the option to see if it worked.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6552 **Author:** [@ggadget6](https://github.com/ggadget6) **Created:** 6/17/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `tabParse` --- ### 📝 Commits (5) - [`6f5d103`](https://github.com/microsoft/terminal/commit/6f5d103674847d118aa7629f36061d5795b8ac39) initial dirty implementation of tab stripping - [`2990ecc`](https://github.com/microsoft/terminal/commit/2990ecca696d606847e8089b1ef350cd8860618b) Resolve issue with std::remove's return value - [`32805e4`](https://github.com/microsoft/terminal/commit/32805e45fd516b803631940b306af6312e612877) Make removing tabs on paste an option - [`f5a30c5`](https://github.com/microsoft/terminal/commit/f5a30c568df75ef3792be262a0943ba26343a915) Address weakThis concerns for RemoveTabsOnPaste() and remove raw new and delete statements. - [`80719d0`](https://github.com/microsoft/terminal/commit/80719d073631d3bb032bcf047203d458b99ada58) Add ReplaceTabsWithSpacesOnPaste with optional int value to replace RemoveTabsOnPaste as an option in PasteFromClipBoard. Add GetOptionalInt() to JsonUtils. ### 📊 Changes **6 files changed** (+57 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+3 -0) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+1 -0) 📝 `src/cascadia/TerminalApp/JsonUtils.cpp` (+17 -0) 📝 `src/cascadia/TerminalApp/JsonUtils.h` (+4 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+31 -7) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Add option to remove tabs that are pasted in (similar to cmd) <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References None, as far as I know <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #6134 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [x] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed I built and loaded the terminal and disabled and enabled the option to see if it worked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:49 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26733