starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6557] [MERGED] Add keybinding to rename tab #26741

New Issue
Open
opened 2026-01-31 09:17:51 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:17:51 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6557
Author: @ggadget6
Created: 6/18/2020
Status: ✅ Merged
Merged: 6/24/2020
Merged by: @undefined

Base: master ← Head: renameBind

📝 Commits (9)

  • 8af1b26 Add .g files to includes and began implementing ActionArgs
  • 160628a Add more things to for ActionArgs
  • 0a9a57c Complete as much left as possible
  • d27098b Add _UpdateTitle call
  • 6c360c8 Remove dead code
  • f457b70 Merge branch 'master' into renameBind
  • 6503c03 Fix line ending issue and finish resolve merge conflict
  • 5f7c55d clean up more formatting errors using clang-format
  • d029755 Fix whitespace errors

📊 Changes

12 files changed (+108 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalApp/ActionAndArgs.cpp (+5 -1)
📝 src/cascadia/TerminalApp/ActionArgs.cpp (+1 -0)
📝 src/cascadia/TerminalApp/ActionArgs.h (+30 -0)
📝 src/cascadia/TerminalApp/ActionArgs.idl (+5 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+26 -0)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.cpp (+5 -0)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.h (+1 -0)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.idl (+4 -1)
📝 src/cascadia/TerminalApp/Tab.cpp (+12 -0)
📝 src/cascadia/TerminalApp/Tab.h (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+13 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+3 -0)

📄 Description

Summary of the Pull Request

Add keybinding for renaming a tab

References

PR Checklist

  • Fulfills format requirements set by #6567
  • CLA signed. If not, go over here and sign the CLA
  • Tests passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #6567 and here (#6557)

This no longer c loses #6256, as the spec changed.

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6557 **Author:** [@ggadget6](https://github.com/ggadget6) **Created:** 6/18/2020 **Status:** ✅ Merged **Merged:** 6/24/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `renameBind` --- ### 📝 Commits (9) - [`8af1b26`](https://github.com/microsoft/terminal/commit/8af1b26dc2511c3805ef213922dbcd7247d88e0f) Add .g files to includes and began implementing ActionArgs - [`160628a`](https://github.com/microsoft/terminal/commit/160628ad0740cf7d695f0306d30a8939dd792d2d) Add more things to for ActionArgs - [`0a9a57c`](https://github.com/microsoft/terminal/commit/0a9a57cc916409ae94a1c0c9f93defcd9342e363) Complete as much left as possible - [`d27098b`](https://github.com/microsoft/terminal/commit/d27098bc0328afe60242b8d231d1404895840830) Add _UpdateTitle call - [`6c360c8`](https://github.com/microsoft/terminal/commit/6c360c8f9392262c75306b381caca86888fb8203) Remove dead code - [`f457b70`](https://github.com/microsoft/terminal/commit/f457b7027af8176ec684141385d243c5540b666d) Merge branch 'master' into renameBind - [`6503c03`](https://github.com/microsoft/terminal/commit/6503c03298c6941c2f1cffe0fb25ccb3424cd77a) Fix line ending issue and finish resolve merge conflict - [`5f7c55d`](https://github.com/microsoft/terminal/commit/5f7c55d4a5fcb2ed618416bc8eceda40929ade4d) clean up more formatting errors using clang-format - [`d029755`](https://github.com/microsoft/terminal/commit/d029755c4dd84f6264d838aa0a336f5d768c05bf) Fix whitespace errors ### 📊 Changes **12 files changed** (+108 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/ActionAndArgs.cpp` (+5 -1) 📝 `src/cascadia/TerminalApp/ActionArgs.cpp` (+1 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+30 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.idl` (+5 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+26 -0) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.cpp` (+5 -0) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.h` (+1 -0) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.idl` (+4 -1) 📝 `src/cascadia/TerminalApp/Tab.cpp` (+12 -0) 📝 `src/cascadia/TerminalApp/Tab.h` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+13 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+3 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Add keybinding for renaming a tab <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Fulfills format requirements set by #6567 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [X] Tests passed * [X] Requires documentation to be updated * [X] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #6567 and here (#6557) This no longer c loses #6256, as the spec changed. <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:51 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26741
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?