[PR #6567] [MERGED] Add setTabColor and openTabColorPicker actions #26743

Open
opened 2026-01-31 09:17:52 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/6567
Author: @zadjii-msft
Created: 6/18/2020
Status: Merged
Merged: 6/25/2020
Merged by: @undefined

Base: masterHead: dev/migrie/f/settabcolor-action


📝 Commits (5)

  • 604c1c0 add setTabColor and resetTabColor actions
  • 3a3a847 change to the openTabColorPicker action instead of resetTabColor
  • 7fd35d8 update the schema
  • 766567f good bot
  • c9b85cc Merge remote-tracking branch 'origin/master' into dev/migrie/f/settabcolor-action

📊 Changes

15 files changed (+207 additions, -13 deletions)

View changed files

📝 .github/actions/spell-check/expect/alphabet.txt (+1 -0)
📝 doc/cascadia/profiles.schema.json (+19 -0)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+59 -0)
📝 src/cascadia/TerminalApp/ActionAndArgs.cpp (+6 -0)
📝 src/cascadia/TerminalApp/ActionArgs.cpp (+1 -0)
📝 src/cascadia/TerminalApp/ActionArgs.h (+37 -0)
📝 src/cascadia/TerminalApp/ActionArgs.idl (+5 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+39 -1)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.cpp (+10 -0)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.h (+2 -0)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.idl (+4 -4)
📝 src/cascadia/TerminalApp/Tab.cpp (+16 -5)
📝 src/cascadia/TerminalApp/Tab.h (+4 -2)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -1)

📄 Description

Summary of the Pull Request

Adds a pair of ShortcutActions for setting the tab color.

  • setTabColor: This changes the color of the current tab to the provided color, or can be used to clear the color.
  • openTabColorPicker: This keybinding immediately activates the tab color picker for the currently focused tab.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • hey look there are tests
  • Tested with the following:

        // { "command": "setTabColor", "keys": [ "alt+c" ] },
        { "keys": "ctrl+alt+c", "command": { "action": "setTabColor", "color": "#123456" } },
        { "keys": "alt+shift+c", "command": { "action": "setTabColor", "color": null} },
        { "keys": "alt+c", "command": "openTabColorPicker" },

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/6567 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/18/2020 **Status:** ✅ Merged **Merged:** 6/25/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/f/settabcolor-action` --- ### 📝 Commits (5) - [`604c1c0`](https://github.com/microsoft/terminal/commit/604c1c0b3c01ca0844a40c1ceaba176271409a58) add setTabColor and resetTabColor actions - [`3a3a847`](https://github.com/microsoft/terminal/commit/3a3a8479261992edebbde304221d971e5a5f01cf) change to the openTabColorPicker action instead of resetTabColor - [`7fd35d8`](https://github.com/microsoft/terminal/commit/7fd35d89d324d7a658bfffeabb883081c404fa28) update the schema - [`766567f`](https://github.com/microsoft/terminal/commit/766567fe8126638f133a6dbb4972098ae5a76407) good bot - [`c9b85cc`](https://github.com/microsoft/terminal/commit/c9b85cc3438eb5e0f28ff333db3b836f47b5c9e4) Merge remote-tracking branch 'origin/master' into dev/migrie/f/settabcolor-action ### 📊 Changes **15 files changed** (+207 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spell-check/expect/alphabet.txt` (+1 -0) 📝 `doc/cascadia/profiles.schema.json` (+19 -0) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+59 -0) 📝 `src/cascadia/TerminalApp/ActionAndArgs.cpp` (+6 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.cpp` (+1 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+37 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.idl` (+5 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+39 -1) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.cpp` (+10 -0) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.h` (+2 -0) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.idl` (+4 -4) 📝 `src/cascadia/TerminalApp/Tab.cpp` (+16 -5) 📝 `src/cascadia/TerminalApp/Tab.h` (+4 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -1) </details> ### 📄 Description ## Summary of the Pull Request Adds a pair of `ShortcutAction`s for setting the tab color. * `setTabColor`: This changes the color of the current tab to the provided color, or can be used to clear the color. * `openTabColorPicker`: This keybinding immediately activates the tab color picker for the currently focused tab. ## References ## PR Checklist * [x] scratches my own itch * [x] I work here * [x] Tests added/passed * [x] https://github.com/MicrosoftDocs/terminal/pull/69 ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed * hey look there are tests * Tested with the following: ```json // { "command": "setTabColor", "keys": [ "alt+c" ] }, { "keys": "ctrl+alt+c", "command": { "action": "setTabColor", "color": "#123456" } }, { "keys": "alt+shift+c", "command": { "action": "setTabColor", "color": null} }, { "keys": "alt+c", "command": "openTabColorPicker" }, ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:17:52 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26743