starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #6812] Update colors of our custom NewTab button to match MUX's TabView #26786

New Issue
Open
opened 2026-01-31 09:18:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:18:08 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/6812

State: closed
Merged: Yes

Update colors of our custom NewTab button to match MUX's TabView button

MUX has a NewTab button, but Terminal uses a homemade lookalike. The
version in Terminal doesn't use the same brush color resources as MUX's
button, so it looks very slightly different. This PR updates Terminal's
button to use the exact same colors that MUX uses. I literally copied
these brush names out of MUX source code.

References

This is the color version of the layout fix #6766
This is a prerequisite for fixing #5360

PR Checklist

Detailed Description of the Pull Request / Additional comments

The real reason that this matters is that once you flip on
ApplicationHighContrastAdjustment::None, the existing colors will not
work at all. The existing brushes are themed to black foreground on a
black background when High Contrast (HC) Black theme is enabled. The
only thing that's saving you is
ApplicationHighContrastAdjustment::Auto is automatically backplating
the glyphs on the buttons, which (by design) hides the fact that the
colors are poor. The backplates are those ugly squares inside the
buttons on the HC themes.

Before I can push a PR that disables automatic backplating (set
ApplicationHighContrastAdjustment to None), we'll need to select
better brushes that work in HC mode. MUX has already selected brushes
that work great in all modes, so it just makes sense to use their
brushes.

If you want to hear some unsubstantiated speculation... read on. I
speculate that when this Terminal code was originally written, the MUX
code was incomplete, so it wasn't possible to copy all of MUX's brushes.
It also may not have been obvious that MUX uses an inconsistent mix of
TabViewButtonXxx and TabViewItemHeaderXxx brushes for this widget, since
the latter is hidden in some styling override code.

Validation Steps Performed

Screenshots! Everybody loves screenshots! These show the button in its
hover state (center button) and normal state (right button).

Theme Old New
Light oldlight newlight
Dark olddark newdark
HC White oldwhite newwhite
HC Black oldblack newblack

The one very subtle difference here is that, for non-HC themes, the
glyph's foreground has a bit more contrast when the button is in
hovered/pressed states. Again this slight difference hardly matters
now, but using the correct brushes will become critical when we try to
remove the HC backplating.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/6812 **State:** closed **Merged:** Yes --- Update colors of our custom NewTab button to match MUX's TabView button MUX has a NewTab button, but Terminal uses a homemade lookalike. The version in Terminal doesn't use the same brush color resources as MUX's button, so it looks very slightly different. This PR updates Terminal's button to use the exact same colors that MUX uses. I literally copied these brush names out of MUX source code. ## References This is the color version of the layout fix #6766 This is a prerequisite for fixing #5360 ## PR Checklist * [X] Closes #6812 ## Detailed Description of the Pull Request / Additional comments The real reason that this matters is that once you flip on `ApplicationHighContrastAdjustment::None`, the existing colors will not work at all. The existing brushes are themed to black foreground on a black background when High Contrast (HC) Black theme is enabled. The only thing that's saving you is `ApplicationHighContrastAdjustment::Auto` is automatically backplating the glyphs on the buttons, which (by design) hides the fact that the colors are poor. The backplates are those ugly squares inside the buttons on the HC themes. Before I can push a PR that disables automatic backplating (set `ApplicationHighContrastAdjustment` to `None`), we'll need to select better brushes that work in HC mode. MUX has already selected brushes that work great in all modes, so it just makes sense to use their brushes. If you want to hear some unsubstantiated speculation... read on. I speculate that when this Terminal code was originally written, the MUX code was incomplete, so it wasn't possible to copy all of MUX's brushes. It also may not have been obvious that MUX uses an inconsistent mix of TabViewButtonXxx and TabViewItemHeaderXxx brushes for this widget, since the latter is hidden in some styling override code. ## Validation Steps Performed Screenshots! Everybody loves screenshots! These show the button in its hover state (center button) and normal state (right button). | Theme | Old | New | | --------------- | --------------- | --------------- | | Light | ![oldlight](https://user-images.githubusercontent.com/10259764/86686402-2ba04480-bfb9-11ea-8f42-1d3c3d820c11.png) | ![newlight](https://user-images.githubusercontent.com/10259764/86686418-2fcc6200-bfb9-11ea-8b97-43d84f2c3c26.png) | | Dark | ![olddark](https://user-images.githubusercontent.com/10259764/86686451-365ad980-bfb9-11ea-8fbc-2f98e9bed942.png) | ![newdark](https://user-images.githubusercontent.com/10259764/86686463-38bd3380-bfb9-11ea-8376-f47c5fa48044.png) | | HC White | ![oldwhite](https://user-images.githubusercontent.com/10259764/86686496-407cd800-bfb9-11ea-8aa8-c8684bf87a40.png) | ![newwhite](https://user-images.githubusercontent.com/10259764/86686529-470b4f80-bfb9-11ea-8def-df7345578674.png) | | HC Black | ![oldblack](https://user-images.githubusercontent.com/10259764/86686556-4d99c700-bfb9-11ea-9483-a513501ac603.png) | ![newblack](https://user-images.githubusercontent.com/10259764/86686575-51c5e480-bfb9-11ea-98ac-c499c8841361.png) | The one very subtle difference here is that, for non-HC themes, the glyph's foreground has a bit more contrast when the button is in hovered/pressed states. Again this slight difference hardly matters now, but using the correct brushes will become critical when we try to remove the HC backplating.
claunia added the pull-request label 2026-01-31 09:18:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26786
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?