starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #7220] [DRAFT] add til::clump<T>, some weird data structure #26868

New Issue
Closed
opened 2026-01-31 09:18:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:18:36 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/7220

State: closed
Merged: No

Summary of the Pull Request

clump is a vector intended to be consumed in chunks.
It is stored as a vector of T with an optional vector
of lengths as a sidecar.
If the length vector is missing, it is assumed that
each component is of length 1.

         +-----------------------------+---------+----+ 
Sizes    | 6                           | 2       | 1  | 
         +--------Region 1-------------+--Rgn 2--+-R3-+ 
Contents | 38 |  2 |  0 | 12 | 34 | 56 |  4 |  2 |  2 | 
         +----+----+----+----+----+----+----+----+----+

During iteration, this clump will produce three spans:

{38, 2, 0, 12, 34, 56}                                  
{4, 2}                                                  
{2}                                                     

Sizes    [ UNSPECIFIED       ]                          
         +----+----+----+----+                          
Contents | 38 |  5 | 68 |  8 |                          
         +----+----+----+----+

During iteration, this clump will produce four spans:

{38}                                                    
{5}                                                     
{68}                                                    
{8}

It's designed like this to be approximately as performant as a vector in the normal case (where there are no sizes specified).

TODO:

  • Tests
  • Fill out this PR body
  • Maybe find a name for it, who knows
  • Try it out in the state machine

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

**Original Pull Request:** https://github.com/microsoft/terminal/pull/7220 **State:** closed **Merged:** No --- ## Summary of the Pull Request clump is a vector intended to be consumed in chunks. It is stored as a vector of T with an optional vector of lengths as a sidecar. If the length vector is missing, it is assumed that each component is of length 1. ``` +-----------------------------+---------+----+ Sizes | 6 | 2 | 1 | +--------Region 1-------------+--Rgn 2--+-R3-+ Contents | 38 | 2 | 0 | 12 | 34 | 56 | 4 | 2 | 2 | +----+----+----+----+----+----+----+----+----+ ``` During iteration, this clump will produce three spans: ``` {38, 2, 0, 12, 34, 56} {4, 2} {2} ``` ``` Sizes [ UNSPECIFIED ] +----+----+----+----+ Contents | 38 | 5 | 68 | 8 | +----+----+----+----+ ``` During iteration, this clump will produce four spans: ``` {38} {5} {68} {8} ``` It's designed like this to be approximately as performant as a vector in the normal case (where there are no sizes specified). TODO: * Tests * Fill out this PR body * Maybe find a name for it, who knows * Try it out in the state machine <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
claunia added the pull-request label 2026-01-31 09:18:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?