[PR #7247] Fix viewport moving when we've scrolled up and circled the buffer #26874

Open
opened 2026-01-31 09:18:38 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/7247

State: closed
Merged: Yes


If you scroll up to view the scrollback, then we want the viewport to
"stay in place", as new output comes in (see #6062). This works fine up
until the buffer circles. In this case, the mutable viewport isn't
actually moving, so we never set updatedViewport to true.

This regressed in #6062
Closes #7222

**Original Pull Request:** https://github.com/microsoft/terminal/pull/7247 **State:** closed **Merged:** Yes --- If you scroll up to view the scrollback, then we want the viewport to "stay in place", as new output comes in (see #6062). This works fine up until the buffer circles. In this case, the mutable viewport isn't actually moving, so we never set `updatedViewport` to true. This regressed in #6062 Closes #7222
claunia added the pull-request label 2026-01-31 09:18:38 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26874