starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #7333] Fix broken localtests #26900

New Issue
Open
opened 2026-01-31 09:18:48 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:18:48 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/7333

State: closed
Merged: Yes

We've had a number of ignored test failures for a while now. They're all
in the localtests, which we don't run in CI, so we've been ignoring
them. Plus, I thought that they were due to some test failure in the way
they were authored, so we just let them be.

Turns out, most of them worked just fine. Many were probably just
temporary test failures that got fixed with subsequent PRs.

The only one that's truly tricky here is the TryCreateTab test
removal. From what I can tell, that test would create a Tab, but not
attach the TabViewItem to the XAML tree at all. But then after the
test was cleaned up, the tab's _UpdateTitle coroutine would resume,
and it would try to get the Tab from the weak_this. That weak
pointer would now be pointing at random memory, and the get_strong
would crash. However, the test runner would already be in the middle
of some other test, so it would cause a failure in a random test, not
the TryCreateTab test.

So I'm just getting rid of it entirely. The TryInitializePage test is
more comprehensive and does work, so we'll just use that (and
derivatives) to test the creation of tabs.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/7333 **State:** closed **Merged:** Yes --- We've had a number of ignored test failures for a while now. They're all in the localtests, which we don't run in CI, so we've been ignoring them. Plus, I thought that they were due to some test failure in the way they were authored, so we just let them be. Turns out, most of them worked just fine. Many were probably just temporary test failures that got fixed with subsequent PRs. The only one that's truly tricky here is the `TryCreateTab` test removal. From what I can tell, that test would create a `Tab`, but not attach the `TabViewItem` to the XAML tree at all. But then after the test was cleaned up, the tab's `_UpdateTitle` coroutine would resume, and it would try to get the `Tab` from the `weak_this`. That weak pointer would now be pointing at _random_ memory, and the `get_strong` would _crash_. However, the test runner would already be in the middle of some other test, so it would cause a failure in a _random_ test, not the `TryCreateTab` test. So I'm just getting rid of it entirely. The `TryInitializePage` test is more comprehensive and _does_ work, so we'll just use that (and derivatives) to test the creation of tabs. * [x] Closes #5169 * [x] Closes #6949 * [x] Closes #7281 * [ ] Might conflict with #6992
claunia added the pull-request label 2026-01-31 09:18:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26900
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?