starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

colortool's 'solarized_dark' theme makes some characters unreadable #270

New Issue
Closed
opened 2026-01-30 21:47:26 +00:00 by claunia · 8 comments
claunia commented 2026-01-30 21:47:26 +00:00
Owner
Copy Link

Originally created by @mikemaccana on GitHub (May 16, 2018).

Your Windows build number: (Type ver at a Windows Command Prompt)

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
Win32NT             10.0.17666.0 Microsoft Windows NT 10.0.17666.0

I don't run command prompt because it's not Windows NT 4.

What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

Using https://github.com/Microsoft/console/releases/download/1708.14008/colortool.zip

 ./colortool -b solarized_dark

image

The '..' in 'cd..' is close to invisible. If you look very closely above, you can see there's two dark blue dots on the dark green background, but you wouldn't see them otherwise.

What's wrong / what should be happening instead:

The blue should be a little lighter than the background.

Originally created by @mikemaccana on GitHub (May 16, 2018). ## Your Windows build number: (Type `ver` at a Windows Command Prompt) [Environment]::OSVersion Platform ServicePack Version VersionString -------- ----------- ------- ------------- Win32NT 10.0.17666.0 Microsoft Windows NT 10.0.17666.0 I don't run command prompt because it's not Windows NT 4. ## What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots) Using https://github.com/Microsoft/console/releases/download/1708.14008/colortool.zip ./colortool -b solarized_dark ![image](https://user-images.githubusercontent.com/172594/40107604-9c09f36a-58f0-11e8-96bf-d359edb121ec.png) The '..' in 'cd..' is close to invisible. If you look very closely above, you can see there's two dark blue dots on the dark green background, but you wouldn't see them otherwise. ## What's wrong / what should be happening instead: The blue should be a little lighter than the background.
claunia added the Product-Colortool label 2026-01-30 21:47:26 +00:00
claunia commented 2026-01-30 21:47:27 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 16, 2018):

I don't run command prompt because it's not Windows NT 4.

Snark is not strictly required to post an issue here.

I'm pretty sure that the solarized theme color values were taken directly from other platforms and as such weren't adjusted for the way that Powershell's PSReadline utility decides to color things.

@zadjii-msft, do you remember where the color values were sourced here? If it does directly match another platform, it's perhaps best we keep this one "pure" to the reference in my mind.

I think maybe we should have a solarized-dark-ps variation as a second option that modifies them to make this better for the particular scenario above.

@mikemaccana, do you have a preferred color value (hex) that you would like assigned to that position? Your guess is as good as ours. You're also welcome to submit a pull to that effect as well and we'll review it and probably merge it.

@miniksa commented on GitHub (May 16, 2018): >I don't run command prompt because it's not Windows NT 4. Snark is not strictly required to post an issue here. I'm pretty sure that the solarized theme color values were taken directly from other platforms and as such weren't adjusted for the way that Powershell's PSReadline utility decides to color things. @zadjii-msft, do you remember where the color values were sourced here? If it does directly match another platform, it's perhaps best we keep this one "pure" to the reference in my mind. I think maybe we should have a `solarized-dark-ps` variation as a second option that modifies them to make this better for the particular scenario above. @mikemaccana, do you have a preferred color value (hex) that you would like assigned to that position? Your guess is as good as ours. You're also welcome to submit a pull to that effect as well and we'll review it and probably merge it.
claunia commented 2026-01-30 21:47:27 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 16, 2018):

@miniksa is exactly right here. You'll notice that even the mbadolato/iTerm2-Color-Schemes repo has 5 different Solarized schemes in it, and IIRC we took it from one of their schemes.

image

The default solarized_dark looks like this:
image

I have a (local) patched version that looks like this:
image

Mainly I switched out the BRIGHT_BLACK with a different gray, and for all the bright colors that were just various shades of gray, I replaced them with the color they have for the dark version of the color. Solarized doesn't really give you that many color options to work with.

Also note at the bottom, cd .. much more visible then before (still not great, but hey, I'm sure that can be fixed with a psreadline configuration setting to not have it be BRIGHT_BLACK on DARK_BLACK)

I can make a PR to add that scheme if that seems good.

@zadjii-msft commented on GitHub (May 16, 2018): @miniksa is exactly right here. You'll notice that even the [mbadolato/iTerm2-Color-Schemes](https://github.com/mbadolato/iTerm2-Color-Schemes) repo has **5** different Solarized schemes in it, and IIRC we took it from one of their schemes. ![image](https://user-images.githubusercontent.com/18356694/40128802-73f98236-58e7-11e8-84e8-47c2ea521aac.png) The default `solarized_dark` looks like this: ![image](https://user-images.githubusercontent.com/18356694/40129105-48b0d07e-58e8-11e8-8bf1-9c28c0065212.png) I have a (local) patched version that looks like this: ![image](https://user-images.githubusercontent.com/18356694/40129124-5934e0b6-58e8-11e8-9f8e-c87d1cf8b198.png) Mainly I switched out the BRIGHT_BLACK with a different gray, and for all the bright colors that were just various shades of gray, I replaced them with the color they have for the dark version of the color. [Solarized](http://ethanschoonover.com/solarized) doesn't really give you that many color options to work with. Also note at the bottom, `cd ..` much more visible then before (still not great, but hey, I'm sure that can be fixed with a psreadline configuration setting to not have it be BRIGHT_BLACK on DARK_BLACK) I can make a PR to add that scheme if that seems good.
claunia commented 2026-01-30 21:47:28 +00:00
Author
Owner
Copy Link

@mikemaccana commented on GitHub (May 16, 2018):

Hey @miniksa! Sorry, I didn't mean to be snarky about ver, just thought it was funny since I assume everyone in https://github.com/Microsoft/console (and most other Windows command line people besides) would be running Powershell 😀.

PR incoming 👍

@mikemaccana commented on GitHub (May 16, 2018): Hey @miniksa! Sorry, I didn't mean to be snarky about `ver`, just thought it was funny since I assume everyone in https://github.com/Microsoft/console (and most other Windows command line people besides) would be running Powershell 😀. PR incoming 👍
claunia commented 2026-01-30 21:47:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 16, 2018):

lol almost everyone on the console team uses cmd, not powershell

@zadjii-msft commented on GitHub (May 16, 2018): lol almost everyone on the console team uses cmd, not powershell
claunia commented 2026-01-30 21:47:28 +00:00
Author
Owner
Copy Link

@mikemaccana commented on GitHub (May 16, 2018):

@zadjii-msft Mike I'm very disappointed. 😉 Thanks to you all for colortool it's rad.

@mikemaccana commented on GitHub (May 16, 2018): @zadjii-msft Mike I'm very disappointed. 😉 Thanks to you all for colortool it's rad.
claunia commented 2026-01-30 21:47:28 +00:00
Author
Owner
Copy Link

@M-Pixel commented on GitHub (Mar 30, 2020):

It appears that this issue has regressed, and should be re-opened. Version 0.10.781.0 from the Windows Store has invisible -Args in PS6 on Solarized Dark, invisible numbers in PS6 on Solarized Light.

@M-Pixel commented on GitHub (Mar 30, 2020): It appears that this issue has regressed, and should be re-opened. Version 0.10.781.0 from the Windows Store has invisible -Args in PS6 on Solarized Dark, invisible numbers in PS6 on Solarized Light.
claunia commented 2026-01-30 21:47:28 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 30, 2020):

The bug you’re commenting on is about ColorTool, not Windows Terminal. It categorically cannot have regressed, because it was resolved almost a year before Terminal even existed. 😄

@DHowett-MSFT commented on GitHub (Mar 30, 2020): The bug you’re commenting on is about ColorTool, not Windows Terminal. It categorically cannot have regressed, because it was resolved almost a year before Terminal even existed. :smile:
claunia commented 2026-01-30 21:47:28 +00:00
Author
Owner
Copy Link

@M-Pixel commented on GitHub (Jun 20, 2020):

@DHowett-MSFT your pedantic comment is unhelpful and appears to serve no end other than mocking my lack of understanding of the role of ColorTool within this application. If you would care to explain what ColorTool is/was and how it is/isn't related to the current Solarized Dark theme in this application, or indicated that other issues were a more appropriate forum, that would have been more helpful than mansplaining and laughing.

I'll move along over to #4047

@M-Pixel commented on GitHub (Jun 20, 2020): @DHowett-MSFT your pedantic comment is unhelpful and appears to serve no end other than mocking my lack of understanding of the role of ColorTool within this application. If you would care to explain what ColorTool is/was and how it is/isn't related to the current Solarized Dark theme in this application, or indicated that other issues were a more appropriate forum, that would have been more helpful than mansplaining and laughing. I'll move along over to #4047
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Product-Colortool
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#270
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?