starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #7938] Rip out the mock ObjectModel in the SUI #27033

New Issue
Closed
opened 2026-01-31 09:19:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:19:36 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/7938

State: closed
Merged: No

This PR's main goal was to get rid of all our ObjectModel references and replace them with references to TSM. Unfortunately I got a little carried away and didn't stop my changes just at that. There's a lot of places in the SUI where I wasn't able to easily drop in the TSM. Usually those settings types aren't as simple as a boolean, so they'll require some templating and finessing. For those settings, I've either commented them out for now or attempted to replace them (and am currently running into some issues). These two pages are ColorSchemes.xaml and MainPage.xaml.

ColorSchemes.xaml is nearly there. It displays all your color schemes in a ComboBox, and as you select your color scheme, the color table updates. The one part I'm having trouble with currently is retrieving the Index from the ColorPicker's Tag and then updating the colortable at that index.

In MainPage.xaml, I've attempted to bind all our profiles to a subitem of the NavigationView, but it isn't working as expected and I'm currently getting some help from XamlDisc, so I've commented most of it out for now.

One thing I've added that will probably need to be used/expanded upon/tidied up is the EnumMapper. The idea is that it should be taking the JSON_ENUM_MAPPERS we've defined and putting the mappings in a WinRT type so that TSE can data bind to these enums.

Drafting it for now because in my hacking away, things are messy and probably have a lot of TODOs sprinkled, so I'm gonna go through all 80 files changed and see what I actually want to push in.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/7938 **State:** closed **Merged:** No --- This PR's main goal was to get rid of all our `ObjectModel` references and replace them with references to `TSM`. Unfortunately I got a little carried away and didn't stop my changes just at that. There's a lot of places in the SUI where I wasn't able to easily drop in the TSM. Usually those settings types aren't as simple as a boolean, so they'll require some templating and finessing. For those settings, I've either commented them out for now or attempted to replace them (and am currently running into some issues). These two pages are `ColorSchemes.xaml` and `MainPage.xaml`. `ColorSchemes.xaml` is nearly there. It displays all your color schemes in a ComboBox, and as you select your color scheme, the color table updates. The one part I'm having trouble with currently is retrieving the Index from the ColorPicker's Tag and then updating the colortable at that index. In `MainPage.xaml`, I've attempted to bind all our profiles to a subitem of the `NavigationView`, but it isn't working as expected and I'm currently getting some help from XamlDisc, so I've commented most of it out for now. One thing I've added that will probably need to be used/expanded upon/tidied up is the `EnumMapper`. The idea is that it should be taking the `JSON_ENUM_MAPPERS` we've defined and putting the mappings in a WinRT type so that TSE can data bind to these enums. Drafting it for now because in my hacking away, things are messy and probably have a lot of TODOs sprinkled, so I'm gonna go through all 80 files changed and see what I actually want to push in.
claunia added the pull-request label 2026-01-31 09:19:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?