[PR #8052] UIA: throw E_FAIL for out-of-bounds text #27071

Open
opened 2026-01-31 09:19:49 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/8052

State: closed
Merged: Yes


In https://github.com/nvaccess/nvda/issues/11428#issuecomment-715893846,
Andre9642 reported a Conhost crash when switching to/from the alt buffer
a few times with a Braille display connected. Upon further
investigation, @carlos-zamora and I discovered that the FailFast was in
GetText: more checks similar to #7677 were needed for this case.

Tested with NVDA using a Focus Braille display.

Improves nvaccess/nvda#11428

**Original Pull Request:** https://github.com/microsoft/terminal/pull/8052 **State:** closed **Merged:** Yes --- In https://github.com/nvaccess/nvda/issues/11428#issuecomment-715893846, Andre9642 reported a Conhost crash when switching to/from the alt buffer a few times with a Braille display connected. Upon further investigation, @carlos-zamora and I discovered that the FailFast was in `GetText`: more checks similar to #7677 were needed for this case. Tested with NVDA using a [Focus](https://www.freedomscientific.com/products/blindness/focus40brailledisplay/) Braille display. Improves nvaccess/nvda#11428
claunia added the pull-request label 2026-01-31 09:19:49 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27071