starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #8219] Bind Launch Mode/Size, BI Opacity, Opacity, and FontWeight #27148

New Issue
Closed
opened 2026-01-31 09:20:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:20:17 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/8219

State: closed
Merged: Yes

Summary of the Pull Request

Properly binds and polishes controls for a few settings in the Settings UI:

  • LaunchMode is now bound to a radio button
  • "Launch size" was added and bound as two number boxes
  • backgroundImageOpacity and acrylicOpacity are now bound to a Slider control
    • A PercentageConverter was introduced to convert from decimal range (0.0-1.0) to whole numbers (0-100)
    • Common styling was added to CommonResources
  • fontWeight is now bound to a combination of controls:
    • ComboBox is used to display the named values (FontWeights docs)
    • A special Custom option is included. When selected, a Slider appears that lets you choose a custom value.
  • AcrylicOpacity slider only appears if useAcrylic is enabled

References

#1564 - Settings UI

Detailed Description of the Pull Request / Additional comments

bf7d06d is the most complicated commit here. FontWeight is exposed as a FontWeight but is constantly treated as a uint16_t. The following changes were made to handle this:

  • FontWeightConverter: bind the slider value to the setting
  • ConversionTrait<FontWeight> stores the values as uint16_t instead of unsigned int
  • ConversionTrait<FontWeight> accepts a range of 1 to 999 in accordance to FontWeight docs
  • manually add and track the CustomFontWeight EnumEntry for the ComboBox. A sentinel value of 0 is used
  • manually implement getter/setter for CurrentFontWeight so that the Slider control is shown/hidden appropriately

Follow-up work for a later PR

The following work items are being added and tracked.

  • non-alphabetical enum ordering
    • FontWeight struggles with this the most. We should order the options from lightest to heaviest.

Demo

Slider Demo

Startup Page

**Original Pull Request:** https://github.com/microsoft/terminal/pull/8219 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Properly binds and polishes controls for a few settings in the Settings UI: - `LaunchMode` is now bound to a radio button - "Launch size" was added and bound as two number boxes - `backgroundImageOpacity` and `acrylicOpacity` are now bound to a Slider control - A `PercentageConverter` was introduced to convert from decimal range (0.0-1.0) to whole numbers (0-100) - Common styling was added to CommonResources - `fontWeight` is now bound to a combination of controls: - ComboBox is used to display the named values ([FontWeights docs](https://docs.microsoft.com/en-us/uwp/api/Windows.UI.Text.FontWeights?view=winrt-19041)) - A special `Custom` option is included. When selected, a Slider appears that lets you choose a custom value. - AcrylicOpacity slider only appears if useAcrylic is enabled ## References #1564 - Settings UI ## Detailed Description of the Pull Request / Additional comments bf7d06d is the most complicated commit here. FontWeight is exposed as a `FontWeight` but is constantly treated as a `uint16_t`. The following changes were made to handle this: - `FontWeightConverter`: bind the slider value to the setting - `ConversionTrait<FontWeight>` stores the values as `uint16_t` instead of `unsigned int` - `ConversionTrait<FontWeight>` accepts a range of 1 to 999 in accordance to [FontWeight docs](https://docs.microsoft.com/en-us/uwp/api/windows.ui.text.fontweight?view=winrt-19041) - manually add and track the `CustomFontWeight` `EnumEntry` for the ComboBox. A sentinel value of 0 is used - manually implement getter/setter for `CurrentFontWeight` so that the Slider control is shown/hidden appropriately ## Follow-up work for a later PR The following work items are being added and tracked. - [ ] non-alphabetical enum ordering - FontWeight struggles with this the most. We should order the options from lightest to heaviest. ## Demo ![Slider Demo](https://user-images.githubusercontent.com/11050425/99599265-d71dc480-29af-11eb-9d8a-e32ba975a69e.gif) ![Startup Page](https://user-images.githubusercontent.com/11050425/100675743-63b77380-331c-11eb-83b9-53e28f004e96.png)
claunia added the pull-request label 2026-01-31 09:20:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?