starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #8649] Fix color animation bug of title bar buttons #27265

New Issue
Open
opened 2026-01-31 09:20:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:20:57 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/8649

State: closed
Merged: Yes

In dark mode (and high contrast mode), color animation of title bar
button uses wrong color. Cause of this issue is using invalid data in
ColorAnimation. I fixed this bug by changing ColorAnimation value
in XAML layout file.

According to a forum post, To value of ColorAnimation must be
frozen. But original source code uses "color binding" which makes this
value dynamic. As a result, the value set by default is always used,
that means, light mode.

So I added new resource named CaptionButtonStrokeColor and
CaptionButtonBackgroundColor which has static color value.

In light mode and dark mode, I set SystemBaseHighColor in the color
resource. SystemBaseHighColor is the same as
SystemControlForegroundBaseHighBrush.Color which is originally used in
animation.

The background color animation happened to work correctly because its
value is the same between light mode and dark mode. But I also fixed
background color animation.

Validation Steps Performed

There is no need to add new test with this fix.

  • I changed the theme value in settings.json and confirmed that the
    correct color values were used.
  • I confirmed that it works correctly even if the Windows theme is
    changed.

Closes #7314

**Original Pull Request:** https://github.com/microsoft/terminal/pull/8649 **State:** closed **Merged:** Yes --- In dark mode (and high contrast mode), color animation of title bar button uses wrong color. Cause of this issue is using invalid data in `ColorAnimation`. I fixed this bug by changing `ColorAnimation` value in XAML layout file. According to a [forum post], `To` value of `ColorAnimation` must be frozen. But original source code uses "color binding" which makes this value dynamic. As a result, the value set by default is always used, that means, light mode. So I added new resource named `CaptionButtonStrokeColor` and `CaptionButtonBackgroundColor` which has static color value. In light mode and dark mode, I set `SystemBaseHighColor` in the color resource. `SystemBaseHighColor` is the same as `SystemControlForegroundBaseHighBrush.Color` which is originally used in animation. The background color animation happened to work correctly because its value is the same between light mode and dark mode. But I also fixed background color animation. ## Validation Steps Performed There is no need to add new test with this fix. - I changed the `theme` value in `settings.json` and confirmed that the correct color values were used. - I confirmed that it works correctly even if the Windows theme is changed. [forum post]: https://social.msdn.microsoft.com/Forums/vstudio/en-US/027c364f-5d75-424f-aafd-7fb76b10b676/templatebinding-on-storyboard?forum=wpf Closes #7314
claunia added the pull-request label 2026-01-31 09:20:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27265
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?