[PR #8895] [MERGED] Fix the erroneous TargetRuntime causing a warning in VS #27323

Open
opened 2026-01-31 09:21:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/8895
Author: @zadjii-msft
Created: 1/26/2021
Status: ✅ Merged
Merged: 1/26/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/b/dustin-why-would-you-do-this


📝 Commits (2)

  • 0cb676e This might not be necessary after all?
  • 26218e1 remove comment for pr

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+1 -2)

📄 Description

Summary of the Pull Request

Apparently, we don't need this TargetRuntime. That's what was causing VS to think that we were a C# project, and give us that warning. This is the solution we got from the owner of the .wapproj plugin.

References

PR Checklist

Build and ran it fine. Changed TermControl, built and ran it fine. Now let's hope CI likes it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/8895 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/26/2021 **Status:** ✅ Merged **Merged:** 1/26/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/dustin-why-would-you-do-this` --- ### 📝 Commits (2) - [`0cb676e`](https://github.com/microsoft/terminal/commit/0cb676e27a02994b49ae5c89c8bd09ce51620f59) This might not be necessary after all? - [`26218e1`](https://github.com/microsoft/terminal/commit/26218e1fba58ed145c33d8e6d592a0bed7ca86fb) remove comment for pr ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+1 -2) </details> ### 📄 Description ## Summary of the Pull Request Apparently, we don't need this `TargetRuntime`. That's what was causing VS to think that we were a C# project, and give us that warning. This is the solution we got from the owner of the `.wapproj` plugin. ## References * Introduced in c33883d8520e2efee233d4af0addff0775327e22, in PR #8062 ## PR Checklist * [x] Closes #8301 * [x] I work here Build and ran it fine. Changed TermControl, built and ran it fine. Now let's hope CI likes it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27323