[PR #8923] [MERGED] Add scrollToTop and scrollToBottom actions to JSON schema #27346

Open
opened 2026-01-31 09:21:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/8923
Author: @cinnamon-msft
Created: 1/28/2021
Status: Merged
Merged: 1/28/2021
Merged by: @DHowett

Base: mainHead: cinnamon/scrollhome-schema


📝 Commits (1)

  • 1cb54c5 add scrolltotop and scrolltobottom

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -0)

📄 Description

Summary of the Pull Request

Simple JSON schema fix for 1.6 :)

scrollToTop and scrollToBottom are from #8459

References

PR Checklist

  • Closes Narrator scan mode crashes terminal (#8892)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/8923 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 1/28/2021 **Status:** ✅ Merged **Merged:** 1/28/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `cinnamon/scrollhome-schema` --- ### 📝 Commits (1) - [`1cb54c5`](https://github.com/microsoft/terminal/commit/1cb54c5c767648eea3be3c7de0421b01731dde6e) add scrolltotop and scrolltobottom ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Simple JSON schema fix for 1.6 :) `scrollToTop` and `scrollToBottom` are from #8459 <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #8892 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [x] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27346