[PR #8962] [MERGED] Added some example images for the pixel shader feature #27351

Open
opened 2026-01-31 09:21:29 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/8962
Author: @CyberMobius
Created: 1/30/2021
Status: Merged
Merged: 2/1/2021
Merged by: @DHowett

Base: mainHead: feature/PixelShaderExampleImages


📝 Commits (1)

  • dd8345a Added some example images for the pixel shader feature

📊 Changes

5 files changed (+13 additions, -1 deletions)

View changed files

📝 samples/PixelShaders/README.md (+13 -1)
samples/PixelShaders/Screenshots/TerminalDefault.PNG (+0 -0)
samples/PixelShaders/Screenshots/TerminalInvert.PNG (+0 -0)
samples/PixelShaders/Screenshots/TerminalRasterbars.PNG (+0 -0)
samples/PixelShaders/Screenshots/TerminalRetro.PNG (+0 -0)

📄 Description

I added some sample screenshots on the README for the pixel shader feature

Fixes #8960

Detailed Description of the Pull Request / Additional comments

I created 4 screenshots using preview windows terminal, one for the default look, and three for the shaders mentioned in the readme.

For the first shader, Invert.hlsl, I put it in a table and placed a screenshot of the default next to it. I don't think it would be clear what the shader did without being able to compare it against the default.

For Rasterbars.hlsl I put a screenshot right after the code sample for it. I added a screenshot for Retro.hlsl just before the last sentence

I also created a folder named Screenshots in terminal/samples/Pixelshaders to hold all of the screenshots.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/8962 **Author:** [@CyberMobius](https://github.com/CyberMobius) **Created:** 1/30/2021 **Status:** ✅ Merged **Merged:** 2/1/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `feature/PixelShaderExampleImages` --- ### 📝 Commits (1) - [`dd8345a`](https://github.com/microsoft/terminal/commit/dd8345addfa1cad051a0e78529ee0e2105059b81) Added some example images for the pixel shader feature ### 📊 Changes **5 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `samples/PixelShaders/README.md` (+13 -1) ➕ `samples/PixelShaders/Screenshots/TerminalDefault.PNG` (+0 -0) ➕ `samples/PixelShaders/Screenshots/TerminalInvert.PNG` (+0 -0) ➕ `samples/PixelShaders/Screenshots/TerminalRasterbars.PNG` (+0 -0) ➕ `samples/PixelShaders/Screenshots/TerminalRetro.PNG` (+0 -0) </details> ### 📄 Description I added some sample screenshots on the README for the pixel shader feature Fixes #8960 ## Detailed Description of the Pull Request / Additional comments I created 4 screenshots using preview windows terminal, one for the default look, and three for the shaders mentioned in the readme. For the first shader, `Invert.hlsl`, I put it in a table and placed a screenshot of the default next to it. I don't think it would be clear what the shader did without being able to compare it against the default. For `Rasterbars.hlsl` I put a screenshot right after the code sample for it. I added a screenshot for `Retro.hlsl` just before the last sentence I also created a folder named Screenshots in `terminal/samples/Pixelshaders` to hold all of the screenshots. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:29 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27351