[PR #8995] [MERGED] Manually initialize the warnings vector to prevent a crash on launch #27360

Open
opened 2026-01-31 09:21:32 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/8995
Author: @zadjii-msft
Created: 2/1/2021
Status: ✅ Merged
Merged: 2/2/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/b/8986-why-would-you-do-this-colorschemes


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -1)

📄 Description

Summary of the Pull Request

Oops, winrt IVectors need to be manually initialized, when default-constructed std::vectors didn't. Simple oversight.

PR Checklist

Validation Steps Performed

Ran the terminal with


    "schemes" :
    [ {} ]

First the crash repro'd, now it doesn't.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/8995 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 2/1/2021 **Status:** ✅ Merged **Merged:** 2/2/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/8986-why-would-you-do-this-colorschemes` --- ### 📝 Commits (1) - [`55869d8`](https://github.com/microsoft/terminal/commit/55869d8b8a71f2f576e5b3766e8ec7b94882517e) why would you do this ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request Oops, winrt `IVector`s need to be manually initialized, when default-constructed `std::vector`s didn't. Simple oversight. ## PR Checklist * [x] Closes #8986 * [x] I work here * [x] A test would be great but ain't nobody got time for that. * [n/a] Requires documentation to be updated ## Validation Steps Performed Ran the terminal with ```json "schemes" : [ {} ] ``` First the crash repro'd, now it doesn't. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:32 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27360