starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #8979] [MERGED] Prevent context menu of tab renamer text box from canceling edit #27362

New Issue
Open
opened 2026-01-31 09:21:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:21:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/8979
Author: @Don-Vito
Created: 1/31/2021
Status: ✅ Merged
Merged: 2/1/2021
Merged by: @undefined

Base: main ← Head: 8975-fix-renamer-context-menu

📝 Commits (1)

  • 84618bb Prevent context menu of tab renamer text box from canceling edit

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/TabHeaderControl.cpp (+8 -0)

📄 Description

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • We dismiss the edit each time HeaderRenamerTextBox loses focus
  • Unfortunately, this applies also to scenario where the context menu
    (copy, paste, select, etc.) is open with the right-click
  • The fix is to ignore focus loss if HeaderRenamerTextBox().ContextFlyout() is open.
  • We can do it as upon the fly-out dismiss the text box regains the focus.

RenamerContextMenu

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/8979 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 1/31/2021 **Status:** ✅ Merged **Merged:** 2/1/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `8975-fix-renamer-context-menu` --- ### 📝 Commits (1) - [`84618bb`](https://github.com/microsoft/terminal/commit/84618bb0c978b62b4e109e8021fdc9eabe944c7d) Prevent context menu of tab renamer text box from canceling edit ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TabHeaderControl.cpp` (+8 -0) </details> ### 📄 Description ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/issues/8975 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments * We dismiss the edit each time `HeaderRenamerTextBox` loses focus * Unfortunately, this applies also to scenario where the context menu (copy, paste, select, etc.) is open with the right-click * The fix is to ignore focus loss if `HeaderRenamerTextBox().ContextFlyout()` is open. * We can do it as upon the fly-out dismiss the text box regains the focus. ![RenamerContextMenu](https://user-images.githubusercontent.com/4639110/106394866-90b10100-6407-11eb-8e92-627be4f70500.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27362
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?