starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #8997] [CLOSED] [Settings UI] [Colour schemes page] Redesign Colour Buttons #27363

New Issue
Open
opened 2026-01-31 09:21:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:21:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/8997
Author: @Chips1234
Created: 2/2/2021
Status: ❌ Closed

Base: main ← Head: dev/chips1234/redesign-colour-buttons-8765

📝 Commits (5)

  • 731c75f Redesign colour buttons
  • 63f86a9 Add non-bright colours row
  • 56d3f42 Split colour table into two
  • 062b9f8 Merge branch 'main' into dev/chips1234/redesign-colour-buttons-8765
  • 3a3477f Fix error

📊 Changes

5 files changed (+269 additions, -75 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp (+66 -24)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.h (+4 -2)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.idl (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml (+134 -27)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+63 -21)

📄 Description

Summary of the Pull Request

Gets rid of labels in favour of tooltips for the colour buttons. Tested manually.

References

Fixes an issue mentioned in #8765:

  • Redesign colour buttons
    • remove text for each colour button (to prevent cropping when text is localized)
    • instead, add a tooltip (and automation property) that includes the label

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Tested manually

Detailed Description of the Pull Request / Additional comments

Tighten margins and make rows narrower.

Terminal Settings UI - Colour buttons

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/8997 **Author:** [@Chips1234](https://github.com/Chips1234) **Created:** 2/2/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/chips1234/redesign-colour-buttons-8765` --- ### 📝 Commits (5) - [`731c75f`](https://github.com/microsoft/terminal/commit/731c75ff840ebb794ebd95e1a6c403cf9204bcdc) Redesign colour buttons - [`63f86a9`](https://github.com/microsoft/terminal/commit/63f86a994cab10b8a057b85d2ab1c6fa5775c130) Add non-bright colours row - [`56d3f42`](https://github.com/microsoft/terminal/commit/56d3f42e2e69ea82fd76a43557a4571543fdd938) Split colour table into two - [`062b9f8`](https://github.com/microsoft/terminal/commit/062b9f8ac670658fae58797f52d769752e5d2793) Merge branch 'main' into dev/chips1234/redesign-colour-buttons-8765 - [`3a3477f`](https://github.com/microsoft/terminal/commit/3a3477f5672274b3eeb25e4c2c48ab92357198c2) Fix error ### 📊 Changes **5 files changed** (+269 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp` (+66 -24) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.h` (+4 -2) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.idl` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml` (+134 -27) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+63 -21) </details> ### 📄 Description ## Summary of the Pull Request Gets rid of labels in favour of tooltips for the colour buttons. Tested manually. ## References Fixes an issue mentioned in #8765: >- [ ] Redesign colour buttons > - remove text for each colour button (to prevent cropping when text is localized) > - instead, add a tooltip (and automation property) that includes the label ## PR Checklist * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [X] Tested manually ## Detailed Description of the Pull Request / Additional comments Tighten margins and make rows narrower. ![Terminal Settings UI - Colour buttons](https://user-images.githubusercontent.com/47545798/106539607-29e92180-64b3-11eb-8531-baca8e9bb404.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27363
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?