starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9041] [MERGED] Introduce zoom, bell and progress indicators to ATS #27400

New Issue
Open
opened 2026-01-31 09:21:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:21:45 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9041
Author: @Don-Vito
Created: 2/4/2021
Status: ✅ Merged
Merged: 2/8/2021
Merged by: @undefined

Base: main ← Head: 8912-ats-progress

📝 Commits (9)

  • 6007f2a Introduce progress bar in ATS
  • ea78f64 Add pane zoom and bell indicators to ATS
  • fb7d73f Add missing copyright to added files
  • 47b4fa6 Fix race when bindings are not updated since CmdPal collapsed
  • 6453712 Fix TabPaletteItem to bind to tab rather than control
  • b41e1a2 Fix column comment
  • b8e87dc Merge remote-tracking branch 'upstream/main' into 8912-ats-progress
  • 341528f Fix column comment
  • f3854d3 Document PaletteItemTemplateSelector

📊 Changes

11 files changed (+302 additions, -78 deletions)

View changed files

📝 src/cascadia/TerminalApp/CommandPalette.cpp (+2 -5)
📝 src/cascadia/TerminalApp/CommandPalette.xaml (+147 -71)
➕ src/cascadia/TerminalApp/PaletteItemTemplateSelector.cpp (+37 -0)
➕ src/cascadia/TerminalApp/PaletteItemTemplateSelector.h (+26 -0)
➕ src/cascadia/TerminalApp/PaletteItemTemplateSelector.idl (+13 -0)
📝 src/cascadia/TerminalApp/TabPaletteItem.cpp (+41 -1)
📝 src/cascadia/TerminalApp/TabPaletteItem.h (+7 -0)
📝 src/cascadia/TerminalApp/TabPaletteItem.idl (+6 -0)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj (+12 -1)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+5 -0)
📝 src/cascadia/TerminalApp/TerminalTab.h (+6 -0)

📄 Description

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Introduced separate DataTemplate for rendering TabPaletteItem
  • Introduced DataTemplateSelector assigning this template
  • Introduced indicators as observable properties of the terminal Tab
  • Bound TabPaletteItem to these properties
  • Ensured that BindingUpdate is always called on CmdPal to avoid races

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9041 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 2/4/2021 **Status:** ✅ Merged **Merged:** 2/8/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `8912-ats-progress` --- ### 📝 Commits (9) - [`6007f2a`](https://github.com/microsoft/terminal/commit/6007f2ae3447aa8a2a1af01712fcaeb4df7e15bb) Introduce progress bar in ATS - [`ea78f64`](https://github.com/microsoft/terminal/commit/ea78f64a63c340ae84df3c12a282b840ff32d9b1) Add pane zoom and bell indicators to ATS - [`fb7d73f`](https://github.com/microsoft/terminal/commit/fb7d73fb84934ce745582808da0e68d11441868d) Add missing copyright to added files - [`47b4fa6`](https://github.com/microsoft/terminal/commit/47b4fa6eaff982e55c3a58a99e1e39777c1d82c5) Fix race when bindings are not updated since CmdPal collapsed - [`6453712`](https://github.com/microsoft/terminal/commit/645371228863364e3c24bb17fe786f53b7d36114) Fix TabPaletteItem to bind to tab rather than control - [`b41e1a2`](https://github.com/microsoft/terminal/commit/b41e1a2d48e9c72e6cdb53bf515a6328bb1ec63a) Fix column comment - [`b8e87dc`](https://github.com/microsoft/terminal/commit/b8e87dc48a92e67747b1edc4da33fad1c3e9d843) Merge remote-tracking branch 'upstream/main' into 8912-ats-progress - [`341528f`](https://github.com/microsoft/terminal/commit/341528f88cb6dd633e7421db16e6cce1200a25bf) Fix column comment - [`f3854d3`](https://github.com/microsoft/terminal/commit/f3854d3928df4aeec9ca2478facba9052e524f8b) Document PaletteItemTemplateSelector ### 📊 Changes **11 files changed** (+302 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CommandPalette.cpp` (+2 -5) 📝 `src/cascadia/TerminalApp/CommandPalette.xaml` (+147 -71) ➕ `src/cascadia/TerminalApp/PaletteItemTemplateSelector.cpp` (+37 -0) ➕ `src/cascadia/TerminalApp/PaletteItemTemplateSelector.h` (+26 -0) ➕ `src/cascadia/TerminalApp/PaletteItemTemplateSelector.idl` (+13 -0) 📝 `src/cascadia/TerminalApp/TabPaletteItem.cpp` (+41 -1) 📝 `src/cascadia/TerminalApp/TabPaletteItem.h` (+7 -0) 📝 `src/cascadia/TerminalApp/TabPaletteItem.idl` (+6 -0) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj` (+12 -1) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+5 -0) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+6 -0) </details> ### 📄 Description ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/issues/8912 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments * Introduced separate DataTemplate for rendering TabPaletteItem * Introduced DataTemplateSelector assigning this template * Introduced indicators as observable properties of the terminal Tab * Bound TabPaletteItem to these properties * Ensured that BindingUpdate is always called on CmdPal to avoid races --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27400
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?