[PR #9076] [MERGED] Fix ATS tab status indicators #27402

Open
opened 2026-01-31 09:21:46 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9076
Author: @Don-Vito
Created: 2/8/2021
Status: Merged
Merged: 2/10/2021
Merged by: @undefined

Base: mainHead: readonly-to-ats


📝 Commits (6)

  • 9ce8af4 Introduce TerminalTabStatus
  • 8335b8e Fix progress update
  • bf6cacd Add readonly indicator to ATS
  • 7178a3b Bind TabHeaderControl to TabStatus
  • 61ee331 Notify TabStatus change to workaround bindings not updated
  • 505b064 Merge remote-tracking branch 'upstream/main' into readonly-to-ats

📊 Changes

15 files changed (+137 additions, -99 deletions)

View changed files

📝 src/cascadia/TerminalApp/CommandPalette.xaml (+14 -6)
📝 src/cascadia/TerminalApp/TabHeaderControl.h (+1 -6)
📝 src/cascadia/TerminalApp/TabHeaderControl.idl (+3 -6)
📝 src/cascadia/TerminalApp/TabHeaderControl.xaml (+8 -8)
📝 src/cascadia/TerminalApp/TabPaletteItem.cpp (+13 -39)
📝 src/cascadia/TerminalApp/TabPaletteItem.h (+2 -6)
📝 src/cascadia/TerminalApp/TabPaletteItem.idl (+2 -5)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj (+11 -0)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj.filters (+4 -1)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+16 -16)
📝 src/cascadia/TerminalApp/TerminalTab.h (+6 -6)
📝 src/cascadia/TerminalApp/TerminalTab.idl (+2 -0)
src/cascadia/TerminalApp/TerminalTabStatus.cpp (+10 -0)
src/cascadia/TerminalApp/TerminalTabStatus.h (+28 -0)
src/cascadia/TerminalApp/TerminalTabStatus.idl (+17 -0)

📄 Description

  1. Fix progress value not updated
  2. Introduce TabStatus object and bind both TabHeaderControl and CommandPalette to it
  3. Add support for read-only mode indicator

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9076 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 2/8/2021 **Status:** ✅ Merged **Merged:** 2/10/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `readonly-to-ats` --- ### 📝 Commits (6) - [`9ce8af4`](https://github.com/microsoft/terminal/commit/9ce8af454a320158ea5e504084056a67506a2f70) Introduce TerminalTabStatus - [`8335b8e`](https://github.com/microsoft/terminal/commit/8335b8e42e808e3925b1df3c41afbdb6f8dad8fb) Fix progress update - [`bf6cacd`](https://github.com/microsoft/terminal/commit/bf6cacd041f117198127a05173479edee181f987) Add readonly indicator to ATS - [`7178a3b`](https://github.com/microsoft/terminal/commit/7178a3b14394cfd4aea5afb52e3eb02efee936f0) Bind TabHeaderControl to TabStatus - [`61ee331`](https://github.com/microsoft/terminal/commit/61ee33171f5fe0e16283e055fa89317e4366ba0d) Notify TabStatus change to workaround bindings not updated - [`505b064`](https://github.com/microsoft/terminal/commit/505b064eccb17c7af2311592b7d7bb705707882a) Merge remote-tracking branch 'upstream/main' into readonly-to-ats ### 📊 Changes **15 files changed** (+137 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CommandPalette.xaml` (+14 -6) 📝 `src/cascadia/TerminalApp/TabHeaderControl.h` (+1 -6) 📝 `src/cascadia/TerminalApp/TabHeaderControl.idl` (+3 -6) 📝 `src/cascadia/TerminalApp/TabHeaderControl.xaml` (+8 -8) 📝 `src/cascadia/TerminalApp/TabPaletteItem.cpp` (+13 -39) 📝 `src/cascadia/TerminalApp/TabPaletteItem.h` (+2 -6) 📝 `src/cascadia/TerminalApp/TabPaletteItem.idl` (+2 -5) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj` (+11 -0) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj.filters` (+4 -1) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+16 -16) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+6 -6) 📝 `src/cascadia/TerminalApp/TerminalTab.idl` (+2 -0) ➕ `src/cascadia/TerminalApp/TerminalTabStatus.cpp` (+10 -0) ➕ `src/cascadia/TerminalApp/TerminalTabStatus.h` (+28 -0) ➕ `src/cascadia/TerminalApp/TerminalTabStatus.idl` (+17 -0) </details> ### 📄 Description 1. Fix progress value not updated 2. Introduce TabStatus object and bind both TabHeaderControl and CommandPalette to it 3. Add support for read-only mode indicator --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:46 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27402